* [gentoo-dev] [PATCH] darcs.eclass: use BDEPEND with EAPI >= 7
@ 2019-05-29 9:00 Michael Haubenwallner
2019-05-29 9:03 ` David Seifert
0 siblings, 1 reply; 8+ messages in thread
From: Michael Haubenwallner @ 2019-05-29 9:00 UTC (permalink / raw
To: gentoo-dev; +Cc: haskell, slyfox, Michael Haubenwallner
---
eclass/darcs.eclass | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/eclass/darcs.eclass b/eclass/darcs.eclass
index 489008a87f1..81003651680 100644
--- a/eclass/darcs.eclass
+++ b/eclass/darcs.eclass
@@ -85,8 +85,16 @@ SRC_URI=""
# --- end ebuild-configurable settings ---
-DEPEND="dev-vcs/darcs
- net-misc/rsync"
+case ${EAPI:-0} in
+ [0-6]*)
+ DEPEND="dev-vcs/darcs
+ net-misc/rsync"
+ ;;
+ *)
+ BDEPEND="dev-vcs/darcs
+ net-misc/rsync"
+ ;;
+esac
# @FUNCTION: darcs_patchcount
# @DESCRIPTION:
--
2.19.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [gentoo-dev] [PATCH] darcs.eclass: use BDEPEND with EAPI >= 7
2019-05-29 9:00 [gentoo-dev] [PATCH] darcs.eclass: use BDEPEND with EAPI >= 7 Michael Haubenwallner
@ 2019-05-29 9:03 ` David Seifert
2019-05-29 9:31 ` Ulrich Mueller
0 siblings, 1 reply; 8+ messages in thread
From: David Seifert @ 2019-05-29 9:03 UTC (permalink / raw
To: gentoo-dev; +Cc: haskell, slyfox, Michael Haubenwallner
On Wed, 2019-05-29 at 11:00 +0200, Michael Haubenwallner wrote:
> ---
> eclass/darcs.eclass | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/eclass/darcs.eclass b/eclass/darcs.eclass
> index 489008a87f1..81003651680 100644
> --- a/eclass/darcs.eclass
> +++ b/eclass/darcs.eclass
> @@ -85,8 +85,16 @@ SRC_URI=""
>
> # --- end ebuild-configurable settings ---
>
> -DEPEND="dev-vcs/darcs
> - net-misc/rsync"
> +case ${EAPI:-0} in
> + [0-6]*)
Why the *? Do we really care about EAPI="5-HDEPEND" and others?
> + DEPEND="dev-vcs/darcs
> + net-misc/rsync"
> + ;;
> + *)
> + BDEPEND="dev-vcs/darcs
> + net-misc/rsync"
> + ;;
> +esac
>
> # @FUNCTION: darcs_patchcount
> # @DESCRIPTION:
Might be worth thinking about adding an EAPI whitelist like we do for
other eclasses. Just an idea, not required.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [gentoo-dev] [PATCH] darcs.eclass: use BDEPEND with EAPI >= 7
2019-05-29 9:03 ` David Seifert
@ 2019-05-29 9:31 ` Ulrich Mueller
2019-05-29 9:33 ` David Seifert
2019-05-29 10:01 ` [gentoo-dev] [PATCH-r1] " Michael Haubenwallner
0 siblings, 2 replies; 8+ messages in thread
From: Ulrich Mueller @ 2019-05-29 9:31 UTC (permalink / raw
To: David Seifert; +Cc: gentoo-dev, haskell, slyfox, Michael Haubenwallner
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
>>>>> On Wed, 29 May 2019, David Seifert wrote:
> On Wed, 2019-05-29 at 11:00 +0200, Michael Haubenwallner wrote:
>> +case ${EAPI:-0} in
>> + [0-6]*)
> Why the *? Do we really care about EAPI="5-HDEPEND" and others?
Worse, this will match EAPI 10. :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [gentoo-dev] [PATCH] darcs.eclass: use BDEPEND with EAPI >= 7
2019-05-29 9:31 ` Ulrich Mueller
@ 2019-05-29 9:33 ` David Seifert
2019-05-29 10:05 ` Michał Górny
2019-05-29 10:01 ` [gentoo-dev] [PATCH-r1] " Michael Haubenwallner
1 sibling, 1 reply; 8+ messages in thread
From: David Seifert @ 2019-05-29 9:33 UTC (permalink / raw
To: Ulrich Mueller; +Cc: gentoo-dev, haskell, slyfox, Michael Haubenwallner
On Wed, 2019-05-29 at 11:31 +0200, Ulrich Mueller wrote:
> > > > > > On Wed, 29 May 2019, David Seifert wrote:
> > On Wed, 2019-05-29 at 11:00 +0200, Michael Haubenwallner wrote:
> > > +case ${EAPI:-0} in
> > > + [0-6]*)
> > Why the *? Do we really care about EAPI="5-HDEPEND" and others?
>
> Worse, this will match EAPI 10. :)
To be honest, I already have nightmares about the EAPI specifier
becoming a two-digit number, so many globs will fail...
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [gentoo-dev] [PATCH] darcs.eclass: use BDEPEND with EAPI >= 7
2019-05-29 9:33 ` David Seifert
@ 2019-05-29 10:05 ` Michał Górny
0 siblings, 0 replies; 8+ messages in thread
From: Michał Górny @ 2019-05-29 10:05 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Wed, 2019-05-29 at 11:33 +0200, David Seifert wrote:
> On Wed, 2019-05-29 at 11:31 +0200, Ulrich Mueller wrote:
> > > > > > > On Wed, 29 May 2019, David Seifert wrote:
> > > On Wed, 2019-05-29 at 11:00 +0200, Michael Haubenwallner wrote:
> > > > +case ${EAPI:-0} in
> > > > + [0-6]*)
> > > Why the *? Do we really care about EAPI="5-HDEPEND" and others?
> >
> > Worse, this will match EAPI 10. :)
>
> To be honest, I already have nightmares about the EAPI specifier
> becoming a two-digit number, so many globs will fail...
>
We'll go for '9a' instead, and then '9za' when we run out of letters.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [gentoo-dev] [PATCH-r1] darcs.eclass: use BDEPEND with EAPI >= 7
2019-05-29 9:31 ` Ulrich Mueller
2019-05-29 9:33 ` David Seifert
@ 2019-05-29 10:01 ` Michael Haubenwallner
2019-05-29 18:51 ` [gentoo-dev] " Sergei Trofimovich
1 sibling, 1 reply; 8+ messages in thread
From: Michael Haubenwallner @ 2019-05-29 10:01 UTC (permalink / raw
To: gentoo-dev; +Cc: haskell, slyfox, Michael Haubenwallner
---
eclass/darcs.eclass | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/eclass/darcs.eclass b/eclass/darcs.eclass
index 489008a87f1..09b71882367 100644
--- a/eclass/darcs.eclass
+++ b/eclass/darcs.eclass
@@ -85,8 +85,16 @@ SRC_URI=""
# --- end ebuild-configurable settings ---
-DEPEND="dev-vcs/darcs
- net-misc/rsync"
+case ${EAPI:-0} in
+ [0-6]) # no need to care about 5-HDEPEND and similar
+ DEPEND="dev-vcs/darcs
+ net-misc/rsync"
+ ;;
+ *)
+ BDEPEND="dev-vcs/darcs
+ net-misc/rsync"
+ ;;
+esac
# @FUNCTION: darcs_patchcount
# @DESCRIPTION:
--
2.19.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [gentoo-dev] Re: [PATCH-r1] darcs.eclass: use BDEPEND with EAPI >= 7
2019-05-29 10:01 ` [gentoo-dev] [PATCH-r1] " Michael Haubenwallner
@ 2019-05-29 18:51 ` Sergei Trofimovich
2019-06-03 8:28 ` Michael Haubenwallner
0 siblings, 1 reply; 8+ messages in thread
From: Sergei Trofimovich @ 2019-05-29 18:51 UTC (permalink / raw
To: Michael Haubenwallner; +Cc: gentoo-dev, haskell
On Wed, 29 May 2019 12:01:20 +0200
Michael Haubenwallner <haubi@gentoo.org> wrote:
> ---
> eclass/darcs.eclass | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/eclass/darcs.eclass b/eclass/darcs.eclass
> index 489008a87f1..09b71882367 100644
> --- a/eclass/darcs.eclass
> +++ b/eclass/darcs.eclass
> @@ -85,8 +85,16 @@ SRC_URI=""
>
> # --- end ebuild-configurable settings ---
>
> -DEPEND="dev-vcs/darcs
> - net-misc/rsync"
> +case ${EAPI:-0} in
> + [0-6]) # no need to care about 5-HDEPEND and similar
> + DEPEND="dev-vcs/darcs
> + net-misc/rsync"
> + ;;
> + *)
> + BDEPEND="dev-vcs/darcs
> + net-misc/rsync"
> + ;;
> +esac
>
> # @FUNCTION: darcs_patchcount
> # @DESCRIPTION:
> --
> 2.19.2
>
Looks good!
--
Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* [gentoo-dev] Re: [PATCH-r1] darcs.eclass: use BDEPEND with EAPI >= 7
2019-05-29 18:51 ` [gentoo-dev] " Sergei Trofimovich
@ 2019-06-03 8:28 ` Michael Haubenwallner
0 siblings, 0 replies; 8+ messages in thread
From: Michael Haubenwallner @ 2019-06-03 8:28 UTC (permalink / raw
To: Sergei Trofimovich; +Cc: gentoo-dev, haskell
pushed, thanks!
/haubi/
On 5/29/19 8:51 PM, Sergei Trofimovich wrote:
> On Wed, 29 May 2019 12:01:20 +0200
> Michael Haubenwallner <haubi@gentoo.org> wrote:
>
>> ---
>> eclass/darcs.eclass | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/eclass/darcs.eclass b/eclass/darcs.eclass
>> index 489008a87f1..09b71882367 100644
>> --- a/eclass/darcs.eclass
>> +++ b/eclass/darcs.eclass
>> @@ -85,8 +85,16 @@ SRC_URI=""
>>
>> # --- end ebuild-configurable settings ---
>>
>> -DEPEND="dev-vcs/darcs
>> - net-misc/rsync"
>> +case ${EAPI:-0} in
>> + [0-6]) # no need to care about 5-HDEPEND and similar
>> + DEPEND="dev-vcs/darcs
>> + net-misc/rsync"
>> + ;;
>> + *)
>> + BDEPEND="dev-vcs/darcs
>> + net-misc/rsync"
>> + ;;
>> +esac
>>
>> # @FUNCTION: darcs_patchcount
>> # @DESCRIPTION:
>> --
>> 2.19.2
>>
>
> Looks good!
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-03 8:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-29 9:00 [gentoo-dev] [PATCH] darcs.eclass: use BDEPEND with EAPI >= 7 Michael Haubenwallner
2019-05-29 9:03 ` David Seifert
2019-05-29 9:31 ` Ulrich Mueller
2019-05-29 9:33 ` David Seifert
2019-05-29 10:05 ` Michał Górny
2019-05-29 10:01 ` [gentoo-dev] [PATCH-r1] " Michael Haubenwallner
2019-05-29 18:51 ` [gentoo-dev] " Sergei Trofimovich
2019-06-03 8:28 ` Michael Haubenwallner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox