From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8FACD138334 for ; Sat, 23 Feb 2019 08:42:47 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 407C3E08F1; Sat, 23 Feb 2019 08:42:44 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DA898E08DC for ; Sat, 23 Feb 2019 08:42:43 +0000 (UTC) Received: from localhost (unknown [91.246.99.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: bircoph) by smtp.gentoo.org (Postfix) with ESMTPSA id 2D23033BE1A for ; Sat, 23 Feb 2019 08:42:40 +0000 (UTC) Date: Sat, 23 Feb 2019 11:42:36 +0300 From: Andrew Savchenko To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 2/3] xorg-2.eclass: Remove use of prune_libtool_files Message-Id: <20190223114236.725b453bdcb03e813507df45@gentoo.org> In-Reply-To: References: <20190220044541.30272-1-mattst88@gentoo.org> <20190220044541.30272-2-mattst88@gentoo.org> <1550648203.1036.5.camel@gentoo.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA512"; boundary="Signature=_Sat__23_Feb_2019_11_42_37_+0300_gGEPXfR7jfgqt.8n" X-Archives-Salt: fddb4946-3e60-445d-afcb-01fac36c0acb X-Archives-Hash: 5f4bf61a7ec1284b4d76456ea5270315 --Signature=_Sat__23_Feb_2019_11_42_37_+0300_gGEPXfR7jfgqt.8n Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, 22 Feb 2019 23:30:15 -0500 desultory wrote: > On 02/20/19 02:36, Micha=C5=82 G=C3=B3rny wrote: > > On Wed, 2019-02-20 at 07:20 +0100, Ulrich Mueller wrote: > >>>>>>> On Wed, 20 Feb 2019, Matt Turner wrote: > >> > >> =20 > >>> # Don't install libtool archives (even for modules) > >>> - prune_libtool_files --all > >>> + find "${D}" -name '*.la' -delete || die > >> > >> Maybe restrict removal to regular files, i.e. add "-type f"? > >=20 > > I suppose you should have spoken up when people started adopting that > > 'find' line all over the place. Though I honestly doubt we're going to > > see many packages installing '*.la' non-files. > >=20 > Just so we are all clear here: your argument is that more fully correct > approaches should not be considered in the present and future because > less fully correct approaches were implemented in the past? And, > further, that since nothing matching a specific pattern happens to come > to your mind at he moment, such things do not exist? Perhaps dialing > back the rhetoric from 11 and considering feedback as an opportunity to > improve existing code is called for in this case, among others. If we are going to improve code, we should also use find -O3.=20 Best regards, Andrew Savchenko --Signature=_Sat__23_Feb_2019_11_42_37_+0300_gGEPXfR7jfgqt.8n Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE63ZIHsdeM+1XgNer9lNaM7oe5I0FAlxxB30ACgkQ9lNaM7oe 5I3l+w//fFPInXJWLyzR45B2QvPDlGG6JhmuIb8EKJnw4WniXRTXxSnreIARPAfV 34OVZGfHPyytkK2a6YxlnhCopSkYZW/ym6mm+b7VH5Y48AImOEm0bfpoFkivTIsC mJZ9OymttX8e63njVlMFsvhaZodKARA8xyatNaaNoLScW+JTdEP3+InweAxyCJlM ke8V4zGXRv6GLU/+3P2/fxo25zGdLBYaiIMgExxQGAqMumbWZ8fR2ra4kIeBFAeT kUAIwLeGstxqDQduq3OGp4n6BVaDeBb5IFeV06R89q0gA0irVngmy0JLyndS/FOV HES/480qFGkKLa65x+KhnzuJKLgdmWMWTiI5D7QSAiuYwWwBGBLywPHfEEiYLwpv 2BcqnlAAZUc2KnqHaT+gJFTAnYgTYfZBo6WPg8gcCFrZyu26r5wuPV43z0LP+khH NABcTNK2lPN1t2sH4G8+u/Idz4CQYChc6KKH4uFkvyySztg5KYWdCZ8d45xkT3u5 zUKCW9HDU4/AeCRnxLfPUCfvA0On9x3DIvAu12mJPfTaB/ppaPXTEaMkoOi8pXlc maGd7AEErbcDoiKJkwiqxf1LoK+tyAW3MubFK5gEKC5DZcP4RFOvqJ2vOPqEzgQS FymNNIqhi1WtKvlZOwU7cYbObEO8/66G55MnyB/BYNGW8F4xJfM= =/O67 -----END PGP SIGNATURE----- --Signature=_Sat__23_Feb_2019_11_42_37_+0300_gGEPXfR7jfgqt.8n--