From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-86657-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id DAE1D138334
	for <garchives@archives.gentoo.org>; Sat, 23 Feb 2019 02:52:33 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 1ACDEE088D;
	Sat, 23 Feb 2019 02:52:29 +0000 (UTC)
Received: from mx-out2.startmail.com (mx-out2.startmail.com [145.131.90.155])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id B3E56E087F
	for <gentoo-dev@lists.gentoo.org>; Sat, 23 Feb 2019 02:52:28 +0000 (UTC)
Date: Fri, 22 Feb 2019 20:51:12 -0600
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=startmail.com;
	s=2017-11; t=1550890347;
	bh=XSSBn82QZSm5A8Bl/cPe4YDKmIJS5NBt8Ns4IM+M0yU=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=E0aLEGKGUz4Djw3Fx54k2ZiT/5+I1TT5fp0DxFyqjdqPd3TcUGAAQInShhBJ7x8tw
	 YtM0sliquYChMk5dWiQl5GeCIEmlWBXGybyVtJwHBXg/LYnYNXY8RqceSMnTSEA2Ks
	 iALefBVp8mKbZYgX8sf3E1o97pY8incQ6k7hNDgrdgMtOW1VLDRq2+yZGlTVFAPCiJ
	 AR5G1tF8GutsfkC5nsX07BxwYxdZKJI5uv7lBKrnOTL/gjEaGy3CHXDkOKwrFbv6Zk
	 u+TOdsLEgz9RHvyxcth9i6nGBaNbOrduZzra8a7evZb0jIhhMcwx5LTmljv6uWaxqw
	 /HRIlMP9oF73A==
From: "Marty E. Plummer" <hanetzer@startmail.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] eclass/java-utils-2: switch to eapi7-ver
Message-ID: <20190223025111.6iokyq2z3gjhhroy@proprietary-killer>
References: <20181217080913.32217-1-hanetzer@startmail.com>
 <1801787.GisAbXGV1V@tuxbrain>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1801787.GisAbXGV1V@tuxbrain>
X-Archives-Salt: 51ac3db6-7046-489b-a81c-db7dfb90f662
X-Archives-Hash: b118e50bd8d3a231d3f60732a92ebcc1

On Thu, Feb 21, 2019 at 03:30:32PM +0100, Andreas Sturmlechner wrote:
> On Montag, 17. Dezember 2018 09:09:13 CET Marty E. Plummer wrote:
> > @@ -15,7 +15,7 @@
> >  # you should inherit java-pkg-2 for Java packages or java-pkg-opt-2 for
> > packages # that have optional Java support. In addition you can inherit
> > java-ant-2 for # Ant-based packages.
> > -inherit eutils versionator multilib
> > +inherit eutils multilib
> 
> I would recommend to keep inheriting all those eclasses (including 
> versionator) for EAPI 0-6, in order not to break revdeps with implicit use. 
> Who knows in what shape they are, and no one is going to fix them for a long 
> time. But we don't want to inherit any of them with EAPI-7, hence merge it 
> with below hunk.
> 
Yeah, I came to the same conclusion when I suggested a move from
versionator to eapi7-ver for gnome.org.eclass and it had implicit deps
on versionator in its consumers.
> > @@ -25,6 +25,9 @@ export WANT_JAVA_CONFIG="2"
> >  # Prefix variables are only available for EAPI>=3
> >  has "${EAPI:-0}" 0 1 2 && ED="${D}" EPREFIX= EROOT="${ROOT}"
> > 
> > +# EAPI 7 has version functions built-in. Use eapi7-ver for all earlier 
> > eclasses.
> > +[[ ${EAPI} == [0123456] ]] && inherit eapi7-ver
> > +
> >  # @VARIABLE: JAVA_PKG_E_DEPEND
> >  # @INTERNAL
> >  # @DESCRIPTION:
> 
> 
> Regards,
> Andreas
> 
> 
>