From: Andrew Savchenko <bircoph@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] fortran-2.eclass: support EAPI 7
Date: Fri, 2 Nov 2018 01:26:42 +0300 [thread overview]
Message-ID: <20181102012642.a7d615262c2d9cac6cb56960@gentoo.org> (raw)
In-Reply-To: <4391372.a9vlhZ2KXN@pinacolada>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
Hi!
On Mon, 29 Oct 2018 23:52:31 +0100 Andreas K. Huettel wrote:
> >
> > -inherit eutils toolchain-funcs
> > +inherit toolchain-funcs
> >
> > case ${EAPI:-0} in
> > - 4|5|6) EXPORT_FUNCTIONS pkg_setup ;;
> > + 4|5|6|7) EXPORT_FUNCTIONS pkg_setup ;;
> > *) die "EAPI=${EAPI} is not supported" ;;
> > esac
> >
>
> ^ The disadvantage of this is that eutils inheritance then suddenly disappears
> for all ebuilds. And you don't know who assumed implicitly somewhere that
> inheriting fortran-2 makes epatch available...
>
> So how about still inheriting eutils for EAPI 4,5,6 and only dropping it for
> EAPI 7 ?!
I agree, backward compatibility matters. Fixed in v2 patch.
Best regards,
Andrew Savchenko
[-- Attachment #2: Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-01 22:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 22:38 [gentoo-dev] [PATCH] fortran-2.eclass: support EAPI 7 Andrew Savchenko
2018-10-28 18:29 ` Michał Górny
2018-10-29 0:57 ` Andrew Savchenko
2018-10-30 7:18 ` Michał Górny
2018-11-01 22:27 ` Andrew Savchenko
2018-11-02 0:47 ` Michael Orlitzky
2018-11-02 14:20 ` Michał Górny
2018-11-05 15:37 ` Andrew Savchenko
2018-10-29 22:52 ` Andreas K. Huettel
2018-11-01 22:26 ` Andrew Savchenko [this message]
2018-11-01 22:25 ` [gentoo-dev] [PATCH v2] " Andrew Savchenko
2018-11-02 10:27 ` Ulrich Mueller
2018-11-05 14:30 ` Andrew Savchenko
2018-11-05 15:37 ` [gentoo-dev] [PATCH v3 2/2] " Andrew Savchenko
2018-11-17 11:38 ` Andrew Savchenko
2018-11-05 15:38 ` [gentoo-dev] [PATCH v3 1/2] " Andrew Savchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102012642.a7d615262c2d9cac6cb56960@gentoo.org \
--to=bircoph@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox