From: James Le Cuirot <chewi@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] xdg-utils.eclass: don't call binaries from ROOT
Date: Wed, 3 Oct 2018 10:23:32 +0100 [thread overview]
Message-ID: <20181003102328.54aa5a30@red.yakaraplc.local> (raw)
In-Reply-To: <1538552033.1042.0.camel@gentoo.org>
On Wed, 03 Oct 2018 09:33:53 +0200
Michał Górny <mgorny@gentoo.org> wrote:
> On Tue, 2018-10-02 at 22:16 -0400, Mike Gilbert wrote:
> > Avoid calling binaries that may have been compiled against different
> > libraries or even cross-compiled for an incomatible arch.
> >
> > Instead, always call the binaries installed in BROOT (/), if
> > available.
>
> Except BROOT doesn't have to be / (that's why we made it into
> a variable)! Also, wouldn't it be sufficient to use PATH lookup here
> and let the PM handle providing the correct root?
To be clearer, EPREFIX refers to the target host, not the build host.
The build host may have a different prefix and that is the point of
BROOT. But as mgorny says, you should just rely on the PATH. We
primarily added BROOT for cases where using the PATH wasn't viable.
> > Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> > ---
> > eclass/xdg-utils.eclass | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/eclass/xdg-utils.eclass b/eclass/xdg-utils.eclass
> > index fe1eef213ea4..b133de093082 100644
> > --- a/eclass/xdg-utils.eclass
> > +++ b/eclass/xdg-utils.eclass
> > @@ -67,7 +67,7 @@ xdg_environment_reset() {
> > # Updates the .desktop files database.
> > # Generates a list of mimetypes linked to applications that can
> > handle them xdg_desktop_database_update() {
> > - local updater="${EROOT%/}${DESKTOP_DATABASE_UPDATE_BIN}"
> > + local updater="${EPREFIX}${DESKTOP_DATABASE_UPDATE_BIN}"
> >
> > if [[ ${EBUILD_PHASE} != post* ]] ; then
> > die "xdg_desktop_database_update must be used in
> > pkg_post* phases." @@ -88,7 +88,7 @@ xdg_desktop_database_update() {
> > # Update the mime database.
> > # Creates a general list of mime types from several sources
> > xdg_mimeinfo_database_update() {
> > - local updater="${EROOT%/}${MIMEINFO_DATABASE_UPDATE_BIN}"
> > + local updater="${EPREFIX}${MIMEINFO_DATABASE_UPDATE_BIN}"
> >
> > if [[ ${EBUILD_PHASE} != post* ]] ; then
> > die "xdg_mimeinfo_database_update must be used in
> > pkg_post* phases."
next prev parent reply other threads:[~2018-10-03 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 2:16 [gentoo-dev] [PATCH] xdg-utils.eclass: don't call binaries from ROOT Mike Gilbert
2018-10-03 7:33 ` Michał Górny
2018-10-03 9:23 ` James Le Cuirot [this message]
2018-10-03 12:05 ` Mike Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003102328.54aa5a30@red.yakaraplc.local \
--to=chewi@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox