From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 04CBA138334 for ; Mon, 1 Oct 2018 13:17:57 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EE7C3E09B0; Mon, 1 Oct 2018 13:17:52 +0000 (UTC) Received: from smtp.gentoo.org (unknown [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 984CBE091D for ; Mon, 1 Oct 2018 13:17:52 +0000 (UTC) Received: from red.yakaraplc.local (host213-123-185-55.in-addr.btopenworld.com [213.123.185.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: chewi) by smtp.gentoo.org (Postfix) with ESMTPSA id 98D40335D97 for ; Mon, 1 Oct 2018 13:17:30 +0000 (UTC) Date: Mon, 1 Oct 2018 14:17:24 +0100 From: James Le Cuirot To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [PATCH 3/5] xdg.eclass: move deps to RDEPEND Message-ID: <20181001141724.58e98ebe@red.yakaraplc.local> In-Reply-To: References: <20180930225035.25434-1-floppym@gentoo.org> <20180930225035.25434-3-floppym@gentoo.org> <2e0b1447-d520-c4cc-61f6-7a1ad1761684@gentoo.org> <1538396835.9799.2.camel@gentoo.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: faa8e67c-da9d-408d-bcb2-b2794600f342 X-Archives-Hash: e6bebb7ea326676bb940d6331ef9e537 On Mon, 1 Oct 2018 09:00:38 -0400 Mike Gilbert wrote: > > The reason why it is in DEPEND though is that none of these tools > > are required at runtime. They are needed at postinst and postrm > > stages which afaik makes them DEPEND on EAPI previous to EAPI 7 and > > BDEPEND in EAPI 7 if I'm not mistaken. > > This is incorrect; programs executed in pkg_postinst/pkg_postrm should > be present in RDEPEND. Consider a binpkg installation, which would > ignore DEPEND, but would still execute pkg_postinst. > > Another option: since xdg-utils.eclass functions will politely skip > the updates if the tools are missing, we could just drop the > dependency from xdg.eclass entirely and wait for the tools to get > installed through some indirect means. Unfortunately there is no correct answer here as we didn't consider this scenario when planning EAPI 7. We should have looked at Exherbo, which does make this important distinction. There is a bug report open. https://bugs.gentoo.org/660306 What I will say is that we should not attempt to executing anything from within ROOT or SYSROOT unless it known to be interpreted (e.g. a shell script) and there is no feasible alternative. I add that exclusion clause because I have been forced to do this with python-config. -- James Le Cuirot (chewi) Gentoo Linux Developer