public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: James Le Cuirot <chewi@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [PATCH 3/5] xdg.eclass: move deps to RDEPEND
Date: Mon, 1 Oct 2018 14:17:24 +0100	[thread overview]
Message-ID: <20181001141724.58e98ebe@red.yakaraplc.local> (raw)
In-Reply-To: <CAJ0EP433tMy1qJj_pKdmZj1cMD50hXNq_mQ561kVzqfKYz3NQg@mail.gmail.com>

On Mon, 1 Oct 2018 09:00:38 -0400
Mike Gilbert <floppym@gentoo.org> wrote:

> > The reason why it is in DEPEND though is that none of these tools
> > are required at runtime. They are needed at postinst and postrm
> > stages which afaik makes them DEPEND on EAPI previous to EAPI 7 and
> > BDEPEND in EAPI 7 if I'm not mistaken.  
> 
> This is incorrect; programs executed in pkg_postinst/pkg_postrm should
> be present in RDEPEND. Consider a binpkg installation, which would
> ignore DEPEND, but would still execute pkg_postinst.
> 
> Another option: since xdg-utils.eclass functions will politely skip
> the updates if the tools are missing, we could just drop the
> dependency from xdg.eclass entirely and wait for the tools to get
> installed through some indirect means.

Unfortunately there is no correct answer here as we didn't consider
this scenario when planning EAPI 7. We should have looked at Exherbo,
which does make this important distinction. There is a bug report open.

https://bugs.gentoo.org/660306

What I will say is that we should not attempt to executing anything
from within ROOT or SYSROOT unless it known to be interpreted
(e.g. a shell script) and there is no feasible alternative. I add that
exclusion clause because I have been forced to do this with
python-config.

-- 
James Le Cuirot (chewi)
Gentoo Linux Developer


  reply	other threads:[~2018-10-01 13:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-30 22:50 [gentoo-dev] [PATCH 1/5] xdg-utils.eclass: avoid duplicate leading slashes Mike Gilbert
2018-09-30 22:50 ` [gentoo-dev] [PATCH 2/5] xdg-utils.eclass: support EAPI 7 Mike Gilbert
2018-09-30 22:50 ` [gentoo-dev] [PATCH 3/5] xdg.eclass: move deps to RDEPEND Mike Gilbert
2018-10-01  5:40   ` [gentoo-dev] " Rémi Cardona
2018-10-01 12:27     ` Gilles Dartiguelongue
2018-10-01 13:00       ` Mike Gilbert
2018-10-01 13:17         ` James Le Cuirot [this message]
2018-10-01 14:08           ` Mike Gilbert
2018-10-02  2:14             ` Marty E. Plummer
2018-10-03  2:22               ` Mike Gilbert
2018-10-03  7:12                 ` Andreas Sturmlechner
2018-10-03 13:23               ` Mike Gilbert
2018-09-30 22:50 ` [gentoo-dev] [PATCH 4/5] xdg.eclass: look for files in ED and cleanup array syntax Mike Gilbert
2018-09-30 22:50 ` [gentoo-dev] [PATCH 5/5] xdg.eclass: support EAPI 7 Mike Gilbert
2018-10-01  6:10   ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181001141724.58e98ebe@red.yakaraplc.local \
    --to=chewi@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox