From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9AFBB138334 for ; Sat, 29 Sep 2018 13:14:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3BF00E0967; Sat, 29 Sep 2018 13:14:22 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E4817E0964 for ; Sat, 29 Sep 2018 13:14:21 +0000 (UTC) Received: from wim.jer (jer.xs4all.nl [212.238.182.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jer) by smtp.gentoo.org (Postfix) with ESMTPSA id 5816E335CDA; Sat, 29 Sep 2018 13:14:20 +0000 (UTC) Date: Sat, 29 Sep 2018 15:14:15 +0200 From: Jeroen Roovers To: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Signed-off-by verification incoming Message-ID: <20180929151415.337aa5b3@wim.jer> In-Reply-To: <1538209150.1199.7.camel@gentoo.org> References: <1538209150.1199.7.camel@gentoo.org> Organization: Gentoo Foundation X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: d2119b92-2275-4fd6-aacf-f4f21548a1a6 X-Archives-Hash: e809044a6bf1bd1f3fe48a4fda6373c9 On Sat, 29 Sep 2018 10:19:10 +0200 Micha=C5=82 G=C3=B3rny wrote: > Hi, everyone. >=20 > Just FYI, I'm going to enable the git hook to verify Signed-off-by > tags on gentoo.git (most likely all repos later on). I've tested it > against all the test cases I could think of but if you have any > trouble pushing, please ping me or others in #-infra. >=20 > Please note that for the hook to work: >=20 > 1. Every commit must contain 'Signed-off-by' of the committer. >=20 > 2. You must use your @gentoo.org address in committer (this was > already enforced) and in Signed-off-by. >=20 > 3. You must use your real name *as stated in LDAP* in Signed-off-by > (committer can be anything). Both regular (cn) and ASCII (gecos) > version is accepted, and the match should be case-insensitive (at > least as far as case-insensitive works in bash). >=20 > If you need to change your real name to match your preferred spelling > (e.g. 'Matt' to 'Matthew'), please ping us as well. >=20 > As a side note, I'd like to repeat that while this is not enforced, > if you merge a copyrightable (i.e. non-trivial) external contribution, > please get Signed-off-by from its author and append yours below it. >=20 remote: 8833535ff8f041d308284149193f5c7322b37b26: no GCO sign-off present remote: e034098e139484cddd1614b55b844898190b21d6: no GCO sign-off present remote: a1c64ac2ac71ef2291d472318d5ffc2218800cd4: no GCO sign-off present remote: 1e846c6372d629171b16282db5ce644577a991fc: no GCO sign-off present remote: e567d8374ec8cbb6f79ac1a3ceef3c71de529d6e: no GCO sign-off present remote: 6131f30065fbff4a50259b81b4e9e88b2ad03661: no GCO sign-off present Please: 0a) Explain to me how to fix my commits that I now can't push, or 0b) disable that hook immediately. 1) Update repoman to enforce it _before_ the commit is executed. 2) Wait for the repoman update to trickle down to all developers. 3) Announce it ahead of time. 4) Re-enable the hook.