From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id ED584138334 for ; Fri, 14 Sep 2018 22:45:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8B317E0A82; Fri, 14 Sep 2018 22:44:52 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3DF90E0A7D for ; Fri, 14 Sep 2018 22:44:52 +0000 (UTC) Received: from symphony.aura-online.co.uk (154.189.187.81.in-addr.arpa [81.187.189.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: chewi) by smtp.gentoo.org (Postfix) with ESMTPSA id 01CA8335D1A; Fri, 14 Sep 2018 22:44:49 +0000 (UTC) From: James Le Cuirot To: gentoo-dev@lists.gentoo.org Cc: python@gentoo.org, James Le Cuirot Subject: [gentoo-dev] [PATCH 2/2] python-utils-r1.eclass: Fix all correct check in python_fix_shebang Date: Fri, 14 Sep 2018 23:44:38 +0100 Message-Id: <20180914224438.29404-2-chewi@gentoo.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180914224438.29404-1-chewi@gentoo.org> References: <20180914224438.29404-1-chewi@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Archives-Salt: b8c347bc-f143-4bea-96fd-3e3280034731 X-Archives-Hash: 0d1d816b9dba83c34d699b915c2aab5a When matching EPYTHON, it would previously call sed and set any_fixed=1 even though it was already correct. If all are correct, it is supposed to raise a QA warning/error. --- eclass/python-utils-r1.eclass | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass index 121f2382ba78..f93235e3f5f4 100644 --- a/eclass/python-utils-r1.eclass +++ b/eclass/python-utils-r1.eclass @@ -1187,8 +1187,7 @@ python_fix_shebang() { # Nothing to do, move along. any_correct=1 - from=${EPYTHON} - break + continue 2 ;; *python|*python[23]) debug-print "${FUNCNAME}: in file ${f#${D%/}}" -- 2.18.0