From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3A403138334 for ; Fri, 7 Sep 2018 14:47:00 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id ACFB5E07D7; Fri, 7 Sep 2018 14:46:56 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5852EE053C for ; Fri, 7 Sep 2018 14:46:56 +0000 (UTC) Received: from red.yakaraplc.local (host213-123-185-55.in-addr.btopenworld.com [213.123.185.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: chewi) by smtp.gentoo.org (Postfix) with ESMTPSA id 68753335CC6 for ; Fri, 7 Sep 2018 14:46:54 +0000 (UTC) Date: Fri, 7 Sep 2018 15:46:48 +0100 From: James Le Cuirot To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/2] eclass: libtool - Mark compatible EAPIs and introduce BDEPEND Message-ID: <20180907154648.55c6150f@red.yakaraplc.local> In-Reply-To: <20180907134701.6812-2-grknight@gentoo.org> References: <20180907134701.6812-1-grknight@gentoo.org> <20180907134701.6812-2-grknight@gentoo.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 1d2ad45e-c89b-49b2-b4e9-c6f158743347 X-Archives-Hash: c80bbfd7151ecdcd1f1f50ac67e0d245 On Fri, 7 Sep 2018 09:47:00 -0400 Brian Evans wrote: > The eltpatch command is run on the build host. > As such, it needs to be in BDEPEND for EAPI 7. > > Also taking this opportunity to list compatible EAPIs to consider > future adjustments. > --- > eclass/libtool.eclass | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/eclass/libtool.eclass b/eclass/libtool.eclass > index 2e0f608d342..942bf34aa27 100644 > --- a/eclass/libtool.eclass > +++ b/eclass/libtool.eclass > @@ -16,7 +17,11 @@ > if [[ -z ${_LIBTOOL_ECLASS} ]]; then > _LIBTOOL_ECLASS=1 > > -DEPEND=">=app-portage/elt-patches-20170422" > +case ${EAPI:-0} in > + 0|1|2|3|4|5|6) DEPEND=">=app-portage/elt-patches-20170422" ;; > + 7) BDEPEND=">=app-portage/elt-patches-20170422" ;; > + *) die "${ECLASS}: EAPI ${EAPI} not supported" ;; > +esac > > inherit toolchain-funcs > Why not take the opportunity to bump elt-patches to 20170815? -- James Le Cuirot (chewi) Gentoo Linux Developer