public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Marty E. Plummer" <hanetzer@startmail.com>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] linux-info.eclass: account for lack of trailing slash
Date: Sat, 14 Jul 2018 02:46:06 -0500	[thread overview]
Message-ID: <20180714074606.ltepua7ey5ct2f2r@proprietary-killer> (raw)
In-Reply-To: <23369.38518.32731.496320@a1i15.kph.uni-mainz.de>

On Sat, Jul 14, 2018 at 08:21:42AM +0200, Ulrich Mueller wrote:
> >>>>> On Fri, 13 Jul 2018, Marty E Plummer wrote:
> 
> > In EAPI 7, D, ED, ROOT, EROOT no longer have a trailing slash[1]. This
> > makes finding /usr/src/linux not work properly as it currently stands.
> 
> > Use the form "${ROOT%/}/" where apropos in order to unify behavior across
> > EAPIs.
> 
> > 1: https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-113001r7
> 
> Please use https://projects.gentoo.org/pms/7/pms.html if you want the
> fragment identifier to be stable (which is not guaranteed for the
> version in my home directory).
> 
Ok, will do.
> > @@ -554,7 +554,7 @@ get_version() {
> >  	# caught before this if they are.
> >  	if [[ -z ${OUTPUT_DIR} ]] ; then
> >  		# Try to locate a kernel that is most relevant for us.
> > -		for OUTPUT_DIR in "${SYSROOT}" "${ROOT}" "" ; do
> > +		for OUTPUT_DIR in "${SYSROOT}" "${ROOT%/}/" "" ; do
> 
> Shouldn't it be "${ROOT%/}" here? Otherwise OUTPUT_DIR may begin with
> a double slash.
> 
Ah, good point. I didn't check that well enough, will fix it up.
> >  			OUTPUT_DIR+="/lib/modules/${KV_MAJOR}.${KV_MINOR}.${KV_PATCH}${KV_EXTRA}/build"
> >  			if [[ -e ${OUTPUT_DIR} ]] ; then
> >  				break




  reply	other threads:[~2018-07-14  7:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 23:57 [gentoo-dev] [PATCH] linux-info.eclass: account for lack of trailing slash Marty E. Plummer
2018-07-14  6:21 ` Ulrich Mueller
2018-07-14  7:46   ` Marty E. Plummer [this message]
2018-07-14  7:52   ` [gentoo-dev] [PATCH v2] " Marty E. Plummer
2018-07-17 18:06     ` [gentoo-dev] [PATCH] linux-info.eclass: fix for prematurely merged patch Marty E. Plummer
  -- strict thread matches above, loose matches on Subject: below --
2018-07-13 23:49 [gentoo-dev] [PATCH] linux-info.eclass: account for lack of trailing slash Marty E. Plummer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180714074606.ltepua7ey5ct2f2r@proprietary-killer \
    --to=hanetzer@startmail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox