From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 402D0138334 for ; Thu, 21 Jun 2018 03:10:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1028AE0963; Thu, 21 Jun 2018 03:10:25 +0000 (UTC) Received: from mx-out1.startmail.com (mx-out1.startmail.com [145.131.90.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EECD1E0956 for ; Thu, 21 Jun 2018 03:10:23 +0000 (UTC) Date: Wed, 20 Jun 2018 22:09:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=startmail.com; s=2017-11; t=1529550622; bh=9/ykWG6mJzQhb9vcOuEdR5v6XqeqF++uGK6PZ6LHBZ0=; h=Date:From:To:Subject:References:In-Reply-To:From; b=ZGwUa+yyJbOoxP/NyqiEATrpHDgSUjHQzKdHLGuacq2bmoklzB8jzpb9HKDri7B9m Dm5ew+UCLEUM2JiC+H+h2tGrSAlZXhKl5t31WjNyZ4M7TK7fH/4eCm9INA387nC7mN NFSLc17qxdB1WqwpXROiBJmIXfQTcVV1WF8fVZOyzRk3mr8Z3RC0P8DGliFgfOMAMO uXK0T+FRGfU4cjtPKDu4tveV7Ezxvnhcl4kVneA7BLXQ7nPe6dTGZ0sI25K9e+VHJl 3zIJOmm3eBbnwpB874tF6G3fPZ00t6nzIiCtk4RnzKMouFzrJV1I58BOPpZslJO2vX E3TQ33+koSBqw== From: "Marty E. Plummer" To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/4] xdg-utils.eclass: make EAPI 7 ready Message-ID: <20180621030920.76eo5abwpguo6n2u@proprietary-killer> References: <20180620071053.11589-1-hanetzer@startmail.com> <20180620130344.GA13850@baraddur.perfinion.com> <20180620222108.qkxgody4hva5j5f3@proprietary-killer> <20180620233353.2efe0c64@symphony.aura-online.co.uk> <20180620230109.zykbkxp3h5jmwefq@proprietary-killer> <20180621023816.GA17503@baraddur.perfinion.com> <8bc10028-9de2-8c87-ff57-537d8cf87c3d@iee.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bc10028-9de2-8c87-ff57-537d8cf87c3d@iee.org> X-Archives-Salt: c6578154-4025-4b26-920f-758e9b5bbb1b X-Archives-Hash: 5f5a6ad319f433f22d1893c28ec645e2 On Thu, Jun 21, 2018 at 03:41:02AM +0100, M. J. Everitt wrote: > On 21/06/18 03:38, Jason Zaman wrote: > > On Wed, Jun 20, 2018 at 06:01:10PM -0500, Marty E. Plummer wrote: > >> On Wed, Jun 20, 2018 at 11:33:53PM +0100, James Le Cuirot wrote: > >>> On Wed, 20 Jun 2018 17:21:09 -0500 > >>> "Marty E. Plummer" wrote: > >>> > >>>> On Wed, Jun 20, 2018 at 09:03:44PM +0800, Jason Zaman wrote: > >>>>> On Wed, Jun 20, 2018 at 02:10:50AM -0500, Marty E. Plummer wrote: > >>>>>> Use ${EROOT%/} whereever possible, as the tools and directories which > >>>>>> are used with it are already prefixed with a / > >>>>>> > >>>>>> Package-Manager: Portage-2.3.40, Repoman-2.3.9 > >>>>>> --- > >>>>>> eclass/xdg-utils.eclass | 10 +++++----- > >>>>>> 1 file changed, 5 insertions(+), 5 deletions(-) > >>>>>> > >>>>>> diff --git a/eclass/xdg-utils.eclass b/eclass/xdg-utils.eclass > >>>>>> index ac075185d8e..8dba5ed6861 100644 > >>>>>> --- a/eclass/xdg-utils.eclass > >>>>>> +++ b/eclass/xdg-utils.eclass > >>>>>> @@ -66,7 +66,7 @@ xdg_environment_reset() { > >>>>>> # Updates the .desktop files database. > >>>>>> # Generates a list of mimetypes linked to applications that can handle them > >>>>>> xdg_desktop_database_update() { > >>>>>> - local updater="${EROOT}${DESKTOP_DATABASE_UPDATE_BIN}" > >>>>>> + local updater="${EROOT%/}${DESKTOP_DATABASE_UPDATE_BIN}" > >>>>> Shouldn't things like this be $BROOT since they're being run? $EROOT > >>>>> might be a different architecture that may or may not run at all on the > >>>>> build machine. > >>>>> > >>>> Good point, but here's a question; if EROOT=${ROOT%/}${EPREFIX}, how do > >>>> we use BROOT here? EBROOT? Or longhand ${BROOT%/}${EPREFIX} ? I think > >>>> that may be a use case that got missed in the EAPI 7 discussions. > >>> BROOT is already prefixed as BROOT without a prefix would just be /. > >>> > >> I don't follow. Its my understanding that BROOT ~= ROOT for most > >> situations. But consider this setup: > >> Ubuntu amd64 with Gentoo Prefix, emerging a native arm @system to > >> /mnt/arm EPREFIX = /home/user/gentoo. > >> > >> In this situation, ROOT=/mnt/arm, EROOT=/mnt/arm, but what is BROOT? /, > >> or /home/usr/gentoo? > > https://dev.gentoo.org/~mgorny/articles/the-ultimate-guide-to-eapi-7.html#broot-variable-for-bdepend > > > > Basically BROOT already contains EPREFIX or BPREFIX or whatever it would > > be called. There is like no need for an un-prefixed BROOT so its just > > merged in. so you should just need "${BROOT}/usr/bin/update-mime-database" > > > > -- Jason > > > >>> -- > >>> James Le Cuirot (chewi) > >>> Gentoo Linux Developer > >> > >> > Obligatory n00b question .. how does this work in EAPI <= 6 ?! :D > I would guess something like has eapi 7 || ROOT = BROOT or whatever. Use BROOT by default and if the EAPI doesn't support it set ROOT to BROOT or somat.