From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2FEEF138334 for ; Thu, 21 Jun 2018 02:38:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 83581E0954; Thu, 21 Jun 2018 02:38:23 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 15BECE093B for ; Thu, 21 Jun 2018 02:38:23 +0000 (UTC) Received: from localhost (unknown [IPv6:2404:e800:e600:402:a043:dee9:8fe1:5766]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: perfinion) by smtp.gentoo.org (Postfix) with ESMTPSA id A345F335C8E for ; Thu, 21 Jun 2018 02:38:21 +0000 (UTC) Date: Thu, 21 Jun 2018 10:38:16 +0800 From: Jason Zaman To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/4] xdg-utils.eclass: make EAPI 7 ready Message-ID: <20180621023816.GA17503@baraddur.perfinion.com> References: <20180620071053.11589-1-hanetzer@startmail.com> <20180620130344.GA13850@baraddur.perfinion.com> <20180620222108.qkxgody4hva5j5f3@proprietary-killer> <20180620233353.2efe0c64@symphony.aura-online.co.uk> <20180620230109.zykbkxp3h5jmwefq@proprietary-killer> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180620230109.zykbkxp3h5jmwefq@proprietary-killer> User-Agent: Mutt/1.9.4 (2018-02-28) X-Archives-Salt: a1c1de2e-e8c8-4eff-83a4-49846d3addfb X-Archives-Hash: dc2a997237997b90fa07d12769def501 On Wed, Jun 20, 2018 at 06:01:10PM -0500, Marty E. Plummer wrote: > On Wed, Jun 20, 2018 at 11:33:53PM +0100, James Le Cuirot wrote: > > On Wed, 20 Jun 2018 17:21:09 -0500 > > "Marty E. Plummer" wrote: > > > > > On Wed, Jun 20, 2018 at 09:03:44PM +0800, Jason Zaman wrote: > > > > On Wed, Jun 20, 2018 at 02:10:50AM -0500, Marty E. Plummer wrote: > > > > > Use ${EROOT%/} whereever possible, as the tools and directories which > > > > > are used with it are already prefixed with a / > > > > > > > > > > Package-Manager: Portage-2.3.40, Repoman-2.3.9 > > > > > --- > > > > > eclass/xdg-utils.eclass | 10 +++++----- > > > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > > > > > diff --git a/eclass/xdg-utils.eclass b/eclass/xdg-utils.eclass > > > > > index ac075185d8e..8dba5ed6861 100644 > > > > > --- a/eclass/xdg-utils.eclass > > > > > +++ b/eclass/xdg-utils.eclass > > > > > @@ -66,7 +66,7 @@ xdg_environment_reset() { > > > > > # Updates the .desktop files database. > > > > > # Generates a list of mimetypes linked to applications that can handle them > > > > > xdg_desktop_database_update() { > > > > > - local updater="${EROOT}${DESKTOP_DATABASE_UPDATE_BIN}" > > > > > + local updater="${EROOT%/}${DESKTOP_DATABASE_UPDATE_BIN}" > > > > > > > > Shouldn't things like this be $BROOT since they're being run? $EROOT > > > > might be a different architecture that may or may not run at all on the > > > > build machine. > > > > > > > Good point, but here's a question; if EROOT=${ROOT%/}${EPREFIX}, how do > > > we use BROOT here? EBROOT? Or longhand ${BROOT%/}${EPREFIX} ? I think > > > that may be a use case that got missed in the EAPI 7 discussions. > > > > BROOT is already prefixed as BROOT without a prefix would just be /. > > > I don't follow. Its my understanding that BROOT ~= ROOT for most > situations. But consider this setup: > Ubuntu amd64 with Gentoo Prefix, emerging a native arm @system to > /mnt/arm EPREFIX = /home/user/gentoo. > > In this situation, ROOT=/mnt/arm, EROOT=/mnt/arm, but what is BROOT? /, > or /home/usr/gentoo? https://dev.gentoo.org/~mgorny/articles/the-ultimate-guide-to-eapi-7.html#broot-variable-for-bdepend Basically BROOT already contains EPREFIX or BPREFIX or whatever it would be called. There is like no need for an un-prefixed BROOT so its just merged in. so you should just need "${BROOT}/usr/bin/update-mime-database" -- Jason > > -- > > James Le Cuirot (chewi) > > Gentoo Linux Developer > > >