From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-84809-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id BA69D138334
	for <garchives@archives.gentoo.org>; Wed, 20 Jun 2018 21:28:44 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 47B37E0B9B;
	Wed, 20 Jun 2018 21:28:39 +0000 (UTC)
Received: from mx-out2.startmail.com (mx-out2.startmail.com [145.131.90.155])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id D0FA2E0B94
	for <gentoo-dev@lists.gentoo.org>; Wed, 20 Jun 2018 21:28:38 +0000 (UTC)
Date: Wed, 20 Jun 2018 16:27:36 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=startmail.com;
	s=2017-11; t=1529530116;
	bh=6juQP+zAH6/6oe5+ysVt7sKA0D6XsTLU3Sm5hLFmVLw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=qGWJsyccUQqBFoZkwcAxN10QW/wGsjliWSO7PTsmtzhVISEIqw684SRYDY1hvkO5B
	 cwJ6S/anLFDpZI4XZB9B15TF53Z16K6TvEe2j4AuPNyBqdXGZrg0T0Ed50Gf9+miA0
	 Hgymxu/Aya+C93xpV7LsxG6LNsh2jxNnmuOCSIDuQz3jSAxoeUYVzrNRE9VGxemt+G
	 dGn/2FzqERgL5wTcCuxgfUjZM53zM49FQv96Y+7XLxX072cRFLeDxnfTBmVsmwCazw
	 GSt5BMxg3fRg5QS5pr93Or9wuZV9R97ki+yoUszDdsFMPt+ZrpLXiGfMmp4AF7OrwZ
	 DM/xgGaxG4YSA==
From: "Marty E. Plummer" <hanetzer@startmail.com>
To: gentoo-dev@lists.gentoo.org
Cc: Michael Haubenwallner <haubi@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 1/5] toolchain.eclass: ROOT->EROOT at
 looking for gcc specs file
Message-ID: <20180620212735.mefb6a32sgmjxvly@proprietary-killer>
References: <20180620174905.7733-1-haubi@gentoo.org>
 <20180620174905.7733-2-haubi@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180620174905.7733-2-haubi@gentoo.org>
X-Archives-Salt: 32fadd05-47f6-42fa-8283-50f1504dde62
X-Archives-Hash: 851d8769a989cb29dcc42f4ad1884413

On Wed, Jun 20, 2018 at 07:49:01PM +0200, Michael Haubenwallner wrote:
> ---
>  eclass/toolchain.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
> index 68e4ce15b37..fe41a80db28 100644
> --- a/eclass/toolchain.eclass
> +++ b/eclass/toolchain.eclass
> @@ -2207,7 +2207,7 @@ do_gcc_config() {
>  		[[ -n ${current_specs} ]] && use_specs=-${current_specs}
>  
>  		if [[ -n ${use_specs} ]] && \
> -		   [[ ! -e ${ROOT}/etc/env.d/gcc/${CTARGET}-${GCC_CONFIG_VER}${use_specs} ]]
> +		   [[ ! -e ${EROOT}etc/env.d/gcc/${CTARGET}-${GCC_CONFIG_VER}${use_specs} ]]
${EROOT%/}/etc... would be more portable, correct? Not all EAPI have no
trailing /.
>  		then
>  			ewarn "The currently selected specs-specific gcc config,"
>  			ewarn "${current_specs}, doesn't exist anymore. This is usually"
> -- 
> 2.16.1
> 
>