public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Marty E. Plummer" <hanetzer@startmail.com>
To: gentoo-dev@lists.gentoo.org
Cc: Michael Haubenwallner <haubi@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 1/5] toolchain.eclass: ROOT->EROOT at looking for gcc specs file
Date: Wed, 20 Jun 2018 16:27:36 -0500	[thread overview]
Message-ID: <20180620212735.mefb6a32sgmjxvly@proprietary-killer> (raw)
In-Reply-To: <20180620174905.7733-2-haubi@gentoo.org>

On Wed, Jun 20, 2018 at 07:49:01PM +0200, Michael Haubenwallner wrote:
> ---
>  eclass/toolchain.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
> index 68e4ce15b37..fe41a80db28 100644
> --- a/eclass/toolchain.eclass
> +++ b/eclass/toolchain.eclass
> @@ -2207,7 +2207,7 @@ do_gcc_config() {
>  		[[ -n ${current_specs} ]] && use_specs=-${current_specs}
>  
>  		if [[ -n ${use_specs} ]] && \
> -		   [[ ! -e ${ROOT}/etc/env.d/gcc/${CTARGET}-${GCC_CONFIG_VER}${use_specs} ]]
> +		   [[ ! -e ${EROOT}etc/env.d/gcc/${CTARGET}-${GCC_CONFIG_VER}${use_specs} ]]
${EROOT%/}/etc... would be more portable, correct? Not all EAPI have no
trailing /.
>  		then
>  			ewarn "The currently selected specs-specific gcc config,"
>  			ewarn "${current_specs}, doesn't exist anymore. This is usually"
> -- 
> 2.16.1
> 
> 


  parent reply	other threads:[~2018-06-20 21:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 17:49 [gentoo-dev] [PATCH 0/5] toolchain.eclass: Prefix patches, Cygwin related Michael Haubenwallner
2018-06-20 17:49 ` [gentoo-dev] [PATCH 1/5] toolchain.eclass: ROOT->EROOT at looking for gcc specs file Michael Haubenwallner
2018-06-20 19:58   ` Michał Górny
2018-06-20 21:27   ` Marty E. Plummer [this message]
2018-06-20 17:49 ` [gentoo-dev] [PATCH 2/5] toolchain.eclass: D->ED for where to start cleanups Michael Haubenwallner
2018-06-20 17:49 ` [gentoo-dev] [PATCH 3/5] toolchain.eclass: avoid leading double slash Michael Haubenwallner
2018-06-20 22:40   ` Ulrich Mueller
2018-06-21  8:16     ` [gentoo-dev] " Michael Haubenwallner
2018-06-21  8:37       ` Marty E. Plummer
2018-06-21  8:39       ` Marty E. Plummer
2018-06-21  8:44         ` Ulrich Mueller
2018-06-20 17:49 ` [gentoo-dev] [PATCH 4/5] toolchain.eclass: Cygwin provides posix threads Michael Haubenwallner
2018-06-20 17:49 ` [gentoo-dev] [PATCH 5/5] toolchain.eclass: support gcc patches from cygwinports Michael Haubenwallner
2018-06-20 19:56   ` Michał Górny
2018-06-22 11:22     ` [gentoo-dev] " Michael Haubenwallner
2018-06-22 12:00       ` Michał Górny
2018-06-22 12:01 ` [gentoo-dev] Re: [PATCH 0/5] toolchain.eclass: Prefix patches, Cygwin related Michael Haubenwallner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180620212735.mefb6a32sgmjxvly@proprietary-killer \
    --to=hanetzer@startmail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=haubi@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox