[gentoo-dev] [PATCH] udev.eclass: return unprefixed udevdir

[gentoo-dev] [PATCH] udev.eclass: return unprefixed udevdir

[Guilherme Amadio]

Hi,

This is a simple fix, but I'd like it to be reviewed.

Without this get_udevdir returns the prefixed directory, leading
to double prefix on udev related packages (e.g. fuse-common).

Even if not used in prefix, udev related packages are usually pulled
in as dependencies of other packages (xrootd for fuse).

Cheers,
-Guilherme

---
diff --git a/eclass/udev.eclass b/eclass/udev.eclass
index 5e5df073880..148581b8bd5 100644
--- a/eclass/udev.eclass
+++ b/eclass/udev.eclass
@@ -46,7 +46,8 @@ DEPEND="virtual/pkgconfig"
 # Get unprefixed udevdir.
 _udev_get_udevdir() {
        if $($(tc-getPKG_CONFIG) --exists udev); then
-               echo "$($(tc-getPKG_CONFIG) --variable=udevdir udev)"
+               local udevdir="$($(tc-getPKG_CONFIG) --variable=udevdir udev)"
+               echo ${udevdir#${EPREFIX%/}}
        else
                echo /lib/udev
        fi

Re: [gentoo-dev] [PATCH] udev.eclass: return unprefixed udevdir

[Mike Gilbert]

On Fri, Jun 8, 2018 at 9:54 AM Guilherme Amadio <amadio@gentoo.org> wrote:
>
> Hi,
>
> This is a simple fix, but I'd like it to be reviewed.
>
> Without this get_udevdir returns the prefixed directory, leading
> to double prefix on udev related packages (e.g. fuse-common).
>
> Even if not used in prefix, udev related packages are usually pulled
> in as dependencies of other packages (xrootd for fuse).
>
> Cheers,
> -Guilherme

Looks good to me.