public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Marty E. Plummer" <hanetzer@startmail.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] freedict.eclass: rename dict.eclass, generalize
Date: Wed, 25 Apr 2018 01:16:00 -0500	[thread overview]
Message-ID: <20180425061558.yfiabbxqu5vwssvg@proprietary-killer> (raw)
In-Reply-To: <23264.4588.243239.14061@a1i15.kph.uni-mainz.de>

On Wed, Apr 25, 2018 at 07:28:12AM +0200, Ulrich Mueller wrote:
> >>>>> On Tue, 24 Apr 2018, Marty E Plummer wrote:
> 
> > Reworked to be usable with app-dicts/dictd-* ebuilds to avoid code
> > duplication
> 
> I don't see much code duplication there, so I think it would be
> cleaner to have a second eclass, rather than adding conditionals to
> the existing one.
> 
I mean if you take into account app-dicts/dictd-* and freedict.eclass;
without the above pr (which I did originally have with a new eclass,
until I realized that app-text/dictd's conf file hardcodes /usr/lib/dict
anyways so the freedict dictionaries get [at least on amd64 and other
targets which use/will use lib64] installed outside of the search path
anyways) they are all almost entirely identical with the contents of
freedict.eclass.

Another thought I had was moving the src_install into dict.eclass and
have freedict inherit it, adding the differences.


  reply	other threads:[~2018-04-25  6:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25  4:03 [gentoo-dev] [PATCH] freedict.eclass: rename dict.eclass, generalize Marty E. Plummer
2018-04-25  4:19 ` Marty E. Plummer
2018-04-25  5:28 ` Ulrich Mueller
2018-04-25  6:16   ` Marty E. Plummer [this message]
2018-04-25  6:47     ` Ulrich Mueller
2018-04-25  7:33       ` Marty E. Plummer
2018-04-25  7:41         ` Ulrich Mueller
2018-04-25  7:00 ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425061558.yfiabbxqu5vwssvg@proprietary-killer \
    --to=hanetzer@startmail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox