[gentoo-dev] [PATCH] cmake-utils.eclass: Override CMAKE_INSTALL_{INFO,MAN}DIR

[gentoo-dev] [PATCH] cmake-utils.eclass: Override CMAKE_INSTALL_{INFO,MAN}DIR

[Michał Górny]

Provide an explicit override for CMAKE_INSTALL_INFODIR
and CMAKE_INSTALL_MANDIR to force Gentoo standards for those locations.
This is needed for Gentoo/FreeBSD where CMake defaults to /usr/info
and /usr/man; while PMS specifies /usr/share/info and /usr/share/man
via econf & do* helpers.
---
 eclass/cmake-utils.eclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
index b9f69a824b14..636927d66491 100644
--- a/eclass/cmake-utils.eclass
+++ b/eclass/cmake-utils.eclass
@@ -602,6 +602,8 @@ cmake-utils_src_configure() {
 		SET (CMAKE_GENTOO_BUILD ON CACHE BOOL "Indicate Gentoo package build")
 		SET (LIB_SUFFIX ${libdir/lib} CACHE STRING "library path suffix" FORCE)
 		SET (CMAKE_INSTALL_LIBDIR ${libdir} CACHE PATH "Output directory for libraries")
+		set (CMAKE_INSTALL_INFODIR "${EPREFIX}/usr/share/info" CACHE PATH "")
+		set (CMAKE_INSTALL_MANDIR "${EPREFIX}/usr/share/man" CACHE PATH "")
 	_EOF_
 	[[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo 'SET (CMAKE_COLOR_MAKEFILE OFF CACHE BOOL "pretty colors during make" FORCE)' >> "${common_config}"
 
-- 
2.16.2

[gentoo-dev] Re: [PATCH] cmake-utils.eclass: Override CMAKE_INSTALL_{INFO,MAN}DIR

[Michael Palimaka]

On 03/02/2018 02:40 AM, Michał Górny wrote:
> Provide an explicit override for CMAKE_INSTALL_INFODIR
> and CMAKE_INSTALL_MANDIR to force Gentoo standards for those locations.
> This is needed for Gentoo/FreeBSD where CMake defaults to /usr/info
> and /usr/man; while PMS specifies /usr/share/info and /usr/share/man
> via econf & do* helpers.
> ---
>  eclass/cmake-utils.eclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
> index b9f69a824b14..636927d66491 100644
> --- a/eclass/cmake-utils.eclass
> +++ b/eclass/cmake-utils.eclass
> @@ -602,6 +602,8 @@ cmake-utils_src_configure() {
>  		SET (CMAKE_GENTOO_BUILD ON CACHE BOOL "Indicate Gentoo package build")
>  		SET (LIB_SUFFIX ${libdir/lib} CACHE STRING "library path suffix" FORCE)
>  		SET (CMAKE_INSTALL_LIBDIR ${libdir} CACHE PATH "Output directory for libraries")
> +		set (CMAKE_INSTALL_INFODIR "${EPREFIX}/usr/share/info" CACHE PATH "")
> +		set (CMAKE_INSTALL_MANDIR "${EPREFIX}/usr/share/man" CACHE PATH "")
>  	_EOF_
>  	[[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo 'SET (CMAKE_COLOR_MAKEFILE OFF CACHE BOOL "pretty colors during make" FORCE)' >> "${common_config}"
>  
> 

There was some discussion in the past about adding these (and some
others), but at that time it was postponed until EAPI 7 due to concerns
about breaking existing packages. What do you think about the risk?

Re: [gentoo-dev] Re: [PATCH] cmake-utils.eclass: Override CMAKE_INSTALL_{INFO,MAN}DIR

[Michał Górny]

W dniu pią, 02.03.2018 o godzinie 19∶53 +1100, użytkownik Michael
Palimaka napisał:
> On 03/02/2018 02:40 AM, Michał Górny wrote:
> > Provide an explicit override for CMAKE_INSTALL_INFODIR
> > and CMAKE_INSTALL_MANDIR to force Gentoo standards for those locations.
> > This is needed for Gentoo/FreeBSD where CMake defaults to /usr/info
> > and /usr/man; while PMS specifies /usr/share/info and /usr/share/man
> > via econf & do* helpers.
> > ---
> >  eclass/cmake-utils.eclass | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
> > index b9f69a824b14..636927d66491 100644
> > --- a/eclass/cmake-utils.eclass
> > +++ b/eclass/cmake-utils.eclass
> > @@ -602,6 +602,8 @@ cmake-utils_src_configure() {
> >  		SET (CMAKE_GENTOO_BUILD ON CACHE BOOL "Indicate Gentoo package build")
> >  		SET (LIB_SUFFIX ${libdir/lib} CACHE STRING "library path suffix" FORCE)
> >  		SET (CMAKE_INSTALL_LIBDIR ${libdir} CACHE PATH "Output directory for libraries")
> > +		set (CMAKE_INSTALL_INFODIR "${EPREFIX}/usr/share/info" CACHE PATH "")
> > +		set (CMAKE_INSTALL_MANDIR "${EPREFIX}/usr/share/man" CACHE PATH "")
> >  	_EOF_
> >  	[[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo 'SET (CMAKE_COLOR_MAKEFILE OFF CACHE BOOL "pretty colors during make" FORCE)' >> "${common_config}"
> >  
> > 
> 
> There was some discussion in the past about adding these (and some
> others), but at that time it was postponed until EAPI 7 due to concerns
> about breaking existing packages. What do you think about the risk?
> 

I think any real-life breakage is unlikely. GNUInstallDirs are not that
popular, and when they are used we can rather expect upstream to be
sane-ish enough not to redefine them with an incompatible meaning.

Then, even if upstream did something crazy that could be affected
by this, it's just documentation, so we shouldn't expect any major
damage.

-- 
Best regards,
Michał Górny