Re: [gentoo-dev] [PATCH] linux-mod.eclass: IUSE default support for MODULES_OPTIONAL_USE

[William Hubbs <williamh@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

On Mon, Jan 15, 2018 at 01:34:12PM -0500, Michael Orlitzky wrote:
> On 01/14/2018 06:53 PM, Robin H. Johnson wrote:
> > +# @ECLASS-VARIABLE: MODULES_OPTIONAL_USE_IUSE_DEFAULT
> > +# @DESCRIPTION:
> > +# A boolean to control the IUSE default state for the MODULES_OPTIONAL_USE USE
> > +# flag. Default value is unset (false). True represented by 1 or 'on', other
> > +# values including unset treated as false.
> > +
> > ...
> > +
> > +case $MODULES_OPTIONAL_USE_IUSE_DEFAULT in
> > +	1) _modules_optional_use_iuse_default='+' ;;
> > +	*) _modules_optional_use_iuse_default='' ;;
> > +esac
> 
> I missed this the first time around, but the case statement needs to
> catch "on", too.

and possibly all other case combinations of on, so On oN ON also have to
be caught,

And since you define it as a boolean, you also need to worry about all
combinations of true.

Honestly what I would do is kill the case completely and use something
like this:

+if [ -n "${MODULES_OPTIONAL_USE_IUSE_DEFAULT}" ]; then
+	_modules_optional_use_iuse_default='+'
+fi

William


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]