From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 569131396D0 for ; Fri, 29 Sep 2017 01:39:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B82062BC019; Fri, 29 Sep 2017 01:39:14 +0000 (UTC) Received: from smx-7fb.smtp.startmail.com (smx-7fb.smtp.startmail.com [37.153.204.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 29DE82BC00C for ; Fri, 29 Sep 2017 01:39:13 +0000 (UTC) Received: from smx-6f5.int1.startmail.com (smx-6f5.int1.startmail.com [10.116.2.63]) by smx-7fb.smtp.startmail.com (Postfix) with ESMTPS id C0D2AB7A61 for ; Fri, 29 Sep 2017 03:39:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=startmail.com; s=dkim; t=1506649152; bh=2sM3Dr7xDt3y5WMG02Iw/6hx0rRbFXKvvOvC5AQHE9g=; h=Date:From:To:Subject:References:In-Reply-To:From; b=AHc4rZDbzQUXEtMpAhGlPODU6cLf2iX7fgr504sapIVjf341PYHyD4fzORE9BGF++ qfN+OQBCO6YoU+Tk7HvRO3yv4REVuRJjUGL1qfa3FEfqAPYe+010AqF9pnzhzxNMh6 ja4HZfev4Y+szTvQdlwVjlD2sv/wIE9YK/d6FbsKU+4YGXxl5B4TAOc9+6Ne8k+wbG cLMGPn7aTVXJikiQFaN2bivSSLeR/G88LvJAqZTPi928pz/y+WA1iOKllzITTwGzCN u5UB1To2xTwqgx9UzVCio6XtlLLks9ngf8RGgvPbX6p7zJhmoLuB6Dtrr+BqP8qf4G MqjLh5rHYY/1w== Date: Thu, 28 Sep 2017 20:36:42 -0500 From: "Marty E. Plummer" To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] sys-libs/ncurses: erronious deletion of *.dll.a files; possibly other packages affected Message-ID: <20170929013637.gz7ntmg4fb62mzel@proprietary-killer.fossland> References:<20170921020139.kp4664tanr7cj77d@proprietary-killer.fossland> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Archives-Salt: f1208183-cca6-40a1-9ceb-4e03fd0577b0 X-Archives-Hash: 4ebc23b3e187f764c46dd3feb9d94937 On Thu, Sep 28, 2017 at 07:35:20PM +0000, Mike Gilbert wrote: > On Wed, Sep 20, 2017 at 10:01 PM, Marty E. Plummer > wrote: > > arfrever suggests I send a mail here, as there are other packages which > > may be affected by this issue and perhaps a more generalized fix is > > required instead of an explicit fix in sys-libs/ncurses and other ebuilds > > that may require it. > > I think the solution here is to remove those overly broad "find > -delete" statements and replace them with something safer. > > Ideally the build system(s) would be patched to not compile static > libs in the first place. > > If that's not possible, perhaps an eclass function could be created to > safely remove static libs. > Honestly I already have a pr up that fixes this particular package's issue, fairly simple fix https://github.com/gentoo/gentoo/pull/5734 --- a/sys-libs/ncurses/ncurses-6.0-r1.ebuild +++ b/sys-libs/ncurses/ncurses-6.0-r1.ebuild @@ -241,7 +241,8 @@ multilib_src_install() { # Provide a link for -lcurses. ln -sf libncurses$(get_libname) "${ED}"/usr/$(get_libdir)/libcurses$(get_libname) || die fi - use static-libs || find "${ED}"/usr/ -name '*.a' -delete + # don't delete '*.dll.a', needed for linking #631468 + use static-libs || find "${ED}"/usr/ -name '*.a' ! -name '*.dll.a' -delete # Build fails to create this ... dosym ../share/terminfo /usr/$(get_libdir)/terminfo and done as far as that goes. Only other issue is the bad symlinking in the original bug report.