From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8941E139694 for ; Mon, 31 Jul 2017 08:35:04 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E3829E0C58; Mon, 31 Jul 2017 08:34:57 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8FE84E0839 for ; Mon, 31 Jul 2017 08:34:57 +0000 (UTC) Received: from gentoo.org (patriceclement.eu [91.121.149.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: monsieurp@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 00C21341969 for ; Mon, 31 Jul 2017 08:34:55 +0000 (UTC) Received: by gentoo.org (nbSMTP-1.00) for uid 1000 (using TLSv1/SSLv3 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) monsieurp@gentoo.org; Mon, 31 Jul 2017 10:34:56 +0200 (CEST) Date: Mon, 31 Jul 2017 10:34:53 +0200 From: Patrice Clement To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] New package neomutt Message-ID: <20170731083453.GI8732@patriceclement.me> References: <20170731071119.jccco5q4kd3fs4xs@rubberducky.suse.de> <20170731072351.xy6r4slccrpni67d@rubberducky.suse.de> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <20170731072351.xy6r4slccrpni67d@rubberducky.suse.de> User-Agent: Mutt/1.7.2 (2016-11-26) X-Archives-Salt: bfd7506f-1576-4c11-a916-5a65b9eb9ac8 X-Archives-Hash: 0a82f221607fffeec0eac09c73091c63 --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Nicolas See my comments inline. Monday 31 Jul 2017 09:23:51, Nicolas Bock wrote : > On Mon, Jul 31, 2017 at 09:11:19AM +0200, Nicolas Bock wrote: > >Hi, > > > >I would like to add neomutt to the tree. This new package is meant as=20 > >an alternative and not a replacement of the existing mutt package. >=20 > I should have inlined the patch. Sorry. >=20 >=20 >=20 > From 63f5d569aec514d67645b1c2e891e51810bb7ab5 Mon Sep 17 00:00:00 2001 > From: Nicolas Bock > Date: Mon, 31 Jul 2017 09:06:07 +0200 > Subject: [PATCH] mail-client/neomutt: New package mail-client/neomutt-201= 70714 >=20 > Package-Manager: Portage-2.3.6, Repoman-2.3.1 > --- > mail-client/neomutt/Manifest | 1 + > mail-client/neomutt/metadata.xml | 24 +++++ > mail-client/neomutt/neomutt-20170714.ebuild | 161 ++++++++++++++++++++++= ++++++ > 3 files changed, 186 insertions(+) > create mode 100644 mail-client/neomutt/Manifest > create mode 100644 mail-client/neomutt/metadata.xml > create mode 100644 mail-client/neomutt/neomutt-20170714.ebuild >=20 > diff --git a/mail-client/neomutt/Manifest b/mail-client/neomutt/Manifest > new file mode 100644 > index 00000000000..2b38484e24d > --- /dev/null > +++ b/mail-client/neomutt/Manifest > @@ -0,0 +1 @@ > +DIST neomutt-20170714.tar.gz 2509160 SHA256 40d48920f95ca49ab96eb109b658= f5cf6e1c222320c58bdd03769c1355d7a383 SHA512 eb31d2f23b7211904cd66ba293c008f= 953778b37f13fd09d4db571d013f1c8e6449fccd827872f3ad0a2c8e62555f92b3f9591a1f0= f4ac37ab362a4681abaaa0 WHIRLPOOL 455495501a2ab1989d5f3bfa75aa2370896956cdfd= 7d2e852e225c96aa23a1abdaf2dbb9d886d1d96486d19b2b38c225e8263f268ebafcef8cbd0= 024885189f3 > diff --git a/mail-client/neomutt/metadata.xml b/mail-client/neomutt/metad= ata.xml > new file mode 100644 > index 00000000000..081f253b3a1 > --- /dev/null > +++ b/mail-client/neomutt/metadata.xml > @@ -0,0 +1,24 @@ > + > + > + > + > + nicolasbock@gentoo.org > + Nicolas Bock > + > + > + net-mail@gentoo.org > + Net-Mail > + > + > + Enable support for app-crypt/gpgme > + Enable support for net-mail/notmuch<= /flag> > + Enable support for S/MIME > + Enable dev-db/tokyocabinet > + database backend for header caching > + > + > + > + > + neomutt/neomutt > + > + > diff --git a/mail-client/neomutt/neomutt-20170714.ebuild b/mail-client/ne= omutt/neomutt-20170714.ebuild > new file mode 100644 > index 00000000000..9bcf72e7479 > --- /dev/null > +++ b/mail-client/neomutt/neomutt-20170714.ebuild > @@ -0,0 +1,161 @@ > +# Copyright 1999-2017 Gentoo Foundation > +# Distributed under the terms of the GNU General Public License v2 > +# $Id$ > + > +EAPI=3D6 > + > +inherit autotools eutils flag-o-matic > + > +DESCRIPTION=3D"A small but very powerful text-based mail client" > +HOMEPAGE=3D"https://www.neomutt.org/" > +SRC_URI=3D"https://github.com/${PN}/${PN}/archive/${P}.tar.gz" > + > +LICENSE=3D"GPL-2" > +SLOT=3D"0" > +KEYWORDS=3D"~amd64 ~x86" > +IUSE=3D"berkdb crypt debug doc gdbm gnutls gpg idn kerberos libressl mbo= x nls > + notmuch qdbm sasl selinux slang smime ssl tokyocabinet vanilla" > + > +CDEPEND=3D" > + !mail-client/mutt > + app-misc/mime-types > + nls? ( virtual/libintl ) > + tokyocabinet? ( dev-db/tokyocabinet ) > + !tokyocabinet? ( > + qdbm? ( dev-db/qdbm ) > + !qdbm? ( > + gdbm? ( sys-libs/gdbm ) > + !gdbm? ( berkdb? ( >=3Dsys-libs/db-4:=3D ) ) > + ) > + ) > + gnutls? ( >=3Dnet-libs/gnutls-1.0.17 ) > + !gnutls? ( > + ssl? ( > + !libressl? ( >=3Ddev-libs/openssl-0.9.6:0 ) > + libressl? ( dev-libs/libressl ) > + ) > + ) > + sasl? ( >=3Ddev-libs/cyrus-sasl-2 ) > + kerberos? ( virtual/krb5 ) > + idn? ( net-dns/libidn ) > + gpg? ( >=3Dapp-crypt/gpgme-0.9.0 ) > + smime? ( > + !libressl? ( >=3Ddev-libs/openssl-0.9.6:0 ) > + libressl? ( dev-libs/libressl ) > + ) > + notmuch? ( net-mail/notmuch ) > + slang? ( sys-libs/slang ) > + !slang? ( >=3Dsys-libs/ncurses-5.2:0 ) > +" > +DEPEND=3D"${CDEPEND} > + net-mail/mailbase > + doc? ( > + dev-libs/libxml2 > + dev-libs/libxslt > + app-text/docbook-xsl-stylesheets > + || ( www-client/lynx www-client/w3m www-client/elinks ) > + )" > +RDEPEND=3D"${CDEPEND} > + selinux? ( sec-policy/selinux-mutt ) > +" > + > +S=3D"${WORKDIR}/${PN}-${P}" > + > +src_prepare() { > + eapply_user > + eautoreconf > +} > + > +src_configure() { > + local myconf=3D( > + "$(use_enable crypt pgp)" > + "$(use_enable debug)" > + "$(use_enable doc)" > + "$(use_enable gpg gpgme)" > + "$(use_enable nls)" > + "$(use_enable smime)" > + "$(use_enable notmuch)" > + "$(use_with idn)" > + "$(use_with kerberos gss)" > + "--with-$(use slang && echo slang || echo curses)=3D${EPREFIX}/usr" > + "--sysconfdir=3D${EPREFIX}/etc/${PN}" > + "--with-docdir=3D${EPREFIX}/usr/share/doc/${PN}-${PVR}" > + ) > + > + if [[ ${CHOST} =3D=3D *-solaris* ]] ; then > + # arrows in index view do not show when using wchar_t > + myconf+=3D( "--without-wc-funcs" ) > + fi > + > + # mutt prioritizes gdbm over bdb, so we will too. > + # hcache feature requires at least one database is in USE. > + local hcaches=3D( > + "tokyocabinet" > + "qdbm" > + "gdbm" > + "berkdb:bdb" > + ) > + local ucache hcache lcache > + for hcache in "${hcaches[@]}" ; do > + if use ${hcache%%:*} ; then > + ucache=3D${hcache} > + break > + fi > + done > + for hcache in "${hcaches[@]}" ; do > + [[ ${hcache} =3D=3D ${ucache} ]] \ > + && myconf+=3D( "--with-${hcache#*:}" ) \ > + || myconf+=3D( "--without-${hcache#*:}" ) > + done Can you simplify this code a little? > + > + # there's no need for gnutls, ssl or sasl without socket support > + if use gnutls; then > + myconf+=3D( "--with-gnutls" ) > + elif use ssl; then > + myconf+=3D( "--with-ssl" ) > + fi > + # not sure if this should be mutually exclusive with the other two > + myconf+=3D( "$(use_with sasl)" ) > + > + if use mbox; then > + myconf+=3D( "--with-mailpath=3D${EPREFIX}/var/spool/mail" ) > + else > + myconf+=3D( "--with-homespool=3DMaildir" ) > + fi > + > + econf "${myconf[@]}" || die "configure failed" econf dies on its own, please nix || die. > +} > + > +src_install() { > + emake DESTDIR=3D"${D}" install || die "install failed" > + if use mbox; then > + insinto /etc/neomutt > + newins "${FILESDIR}"/Muttrc.mbox Muttrc > + else > + insinto /etc/neomutt > + doins "${FILESDIR}"/Muttrc > + fi > + > + # A newer file is provided by app-misc/mime-types. So we link it. > + rm "${ED}"/etc/${PN}/mime.types Please append || die here. > + dosym /etc/mime.types /etc/${PN}/mime.types > + > + # A man-page is always handy, so fake one > + if use !doc; then > + emake -C doc DESTDIR=3D"${D}" muttrc.man || die emake dies on its own. > + # make the fake slightly better, bug #413405 > + sed -e 's#@docdir@/manual.txt#http://www.mutt.org/doc/devel/manual.htm= l#' \ > + -e 's#in @docdir@,#at http://www.mutt.org/,#' \ > + -e "s#@sysconfdir@#${EPREFIX}/etc/${PN}#" \ > + -e "s#@bindir@#${EPREFIX}/usr/bin#" \ > + doc/mutt.man > mutt.1 Ditto, append || die here as well. > + cp doc/muttrc.man muttrc.5 Ditto. > + doman mutt.1 muttrc.5 > + else > + # nuke manpages that should be provided by an MTA, bug #177605 > + rm "${ED}"/usr/share/man/man5/{mbox,mmdf}.5 \ > + || ewarn "failed to remove files, please file a bug" > + fi > + > + dodoc COPYRIGHT ChangeLog.md OPS* README* > +} > --=20 > 2.13.0 >=20 >=20 > --=20 > Nicolas Bock --=20 Patrice Clement Gentoo Linux developer http://www.gentoo.org --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEE91vd2yfjBCryrarpkZGl8ZNJG7gFAll+66sACgkQkZGl8ZNJ G7jjgQf+KRcRBSxaFOdcxruTejNPWcEnQkrTcVqPNmaFVvNTZxPxNcYBz0Y1TOMV C0Bi4dqrhZSi1aK7sZqpQUzoP+lUa86BRmZ2UTgKUawMyDUvRvsSWM7VjYu7W5Ux c37yxxqkqFwmyaMfjgRxCLbClNFTXuaws7kxHTS8X1CTLt/4AZhDY9QNtbVMk2jB 3/qNFjLzrzDh8Nw467/GJzs+aH6G25jPDFvv90BGlxmq5BOLZyfSB+gE3a96LvWh 50SpWi62vvgJWFRk5wv6rm2Sp6Y63Y5RGafUq8Wm9uE72sO7P9/6+Fs5ezC/xA/S B6wMARnKjin8hiXAgvITvqvyVwQCrQ== =Foik -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--