From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BA2F3139694 for ; Sun, 30 Jul 2017 21:08:38 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 612821FC105; Sun, 30 Jul 2017 21:08:33 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 12A7E1FC0B0 for ; Sun, 30 Jul 2017 21:08:32 +0000 (UTC) Received: from symphony.aura-online.co.uk (154.189.187.81.in-addr.arpa [81.187.189.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: chewi) by smtp.gentoo.org (Postfix) with ESMTPSA id 6B29C341870 for ; Sun, 30 Jul 2017 21:08:30 +0000 (UTC) Date: Sun, 30 Jul 2017 22:08:18 +0100 From: James Le Cuirot To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] java-pkg-opt-2.eclass: fix java-pkg-opt-2_src_prepare to always call eapply_user for EAPI-6+ Message-ID: <20170730220818.7ca800df@symphony.aura-online.co.uk> In-Reply-To: <20170730143253.f8ccf2b2cb849b95133d2546@gentoo.org> References: <20170730143253.f8ccf2b2cb849b95133d2546@gentoo.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/bInCZVUe7j+y20hQRNS7SiL"; protocol="application/pgp-signature" X-Archives-Salt: 8d30488a-60e3-4eac-8134-06f5d1dce298 X-Archives-Hash: a34babcedb9fb7f1efc3751540790b4e --Sig_/bInCZVUe7j+y20hQRNS7SiL Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 30 Jul 2017 14:32:53 +0300 Andrew Savchenko wrote: > For EAPI 6+ java-pkg-opt-2_src_prepare() has eapply_user call via > java-utils-2_src_prepare() from java-utils-2.eclass. But > java-utils-2_src_prepare() call is conditional and in case when > package is build with USE=3D-java java-utils-2_src_prepare() is not > called, hence eapply_user is not called in src_prepare phase and > ebuild fails. >=20 > The following patch fixes this by calling eapply_user if java USE > is disabled _and_ EAPI is 6+. This makes sense so no problem here. > [pedantic mode on] > Strictly speaking when EAPI is other than [0-5]. The way java-* > eclasses are now, they assume ![0-5] =3D=3D 6+. It may be speculated > that this is not entirely correct and many other eclasses > explicitly deny all unknown EAPIs. If someone is interesting in > fixing this issue, please handle it with the java team and do not > mix it into the problem described at the beginning. My goal now is > to fix eapply_user issue which cases trouble for any EAPI 6 > packages with optional java support and default src_prepare() at > the ebuild scope. > [pedantic mode off] Agreed. I don't think java-utils-2_src_prepare() should be changed in this regard as the behaviour may continue to be correct but the eclass should have a global EAPI check that forbids anything beyond 6 like other eclasses do. --=20 James Le Cuirot (chewi) Gentoo Linux Developer --Sig_/bInCZVUe7j+y20hQRNS7SiL Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQKTBAEBCgB9FiEEUo3mvYaRpDkf2i7UIcYyEpxtfeQFAll+SsJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDUy OERFNkJEODY5MUE0MzkxRkRBMkVENDIxQzYzMjEyOUM2RDdERTQACgkQIcYyEpxt feRgpg//SEhaexZFTjbrA7Niik7zIMLWm0+nLL98If1P1e6D22qPy7Gnw4j5Jbzp E0B7fHYmnCt96AfcrshECJZTcN/3aML07TrHTFgzvrYxE0tBkXuNanuwVcpZqkRA IYhIjQ8vJTTy2WT7I0K8Wj1oEkjHj+6PHEyGdkp4oDg6gDlMMZnjtTIYI1Nd+4ot fS7il5elc9FSrnWur64M6WGhni676o8dOlproz2ixgkO7E0SFEWnEjMr2Tzd4Zm2 /yjBFey1pnKVcebIH36x8nrHStrTGjoonDqVPXhVNBPy4j20bG2bba+gDWX+eJQ+ QrxUdRjJ18l620TYk3IYQRbyn2BVGSiC9nlxNPVl9m7fp6t3hClLwAgXDhTstl4D Qhv4L0pGbhLLuPvYDtD6Yx1Wsa+Iu/MPLnkSn/WOoZrCGFC+3H7jAN+gopQ31t6u hTR/JI6L6AbPjFBdSqEGQDIvhaWO06BqOh6F3deX4LgpV5Ln47Ag09CuH63FoDVS VOM+mV+PbCcxs07+HLRbCA+sBcl/qZTigy2p3B9GH8td70rKPzfbtPuuuFaaIM89 BQeiqE9RMgk25nv+XTKFqV+XcTUBIWFtbI4aFakthDC9kqtA6T00ud35Vn5r6r4j 7yVmyOAJRtjY6ghMCDxHXQHeTpF0tHDWa0Le6WchLzZX6rc1bxM= =iHiG -----END PGP SIGNATURE----- --Sig_/bInCZVUe7j+y20hQRNS7SiL--