From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 06248139694 for ; Tue, 25 Jul 2017 08:26:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5BFB5E0DA0; Tue, 25 Jul 2017 08:26:05 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 190B8E0D6F for ; Tue, 25 Jul 2017 08:26:05 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e34:eeaa:6bd0:4ecc:6aff:fe03:1cfc]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id BACD83416F3 for ; Tue, 25 Jul 2017 08:26:03 +0000 (UTC) Date: Tue, 25 Jul 2017 10:25:58 +0200 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] New eclass: opam.eclass Message-ID: <20170725102558.79b2cbaa@gentoo.org> In-Reply-To: <20170724221139.GC15937@gengoff> References: <20170724172032.0a6623dc@gentoo.org> <20170724221139.GC15937@gengoff> Organization: Gentoo X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 6fac9af9-0ed3-49fd-91d8-375dd47fa055 X-Archives-Hash: c5aa45ae32c99b57b3e2e94416ff0d36 On Mon, 24 Jul 2017 18:11:39 -0400 "Aaron W. Swenson" wrote: > On 2017-07-24 17:20, Alexis Ballier wrote: > > Hey, > >=20 > > Here is an eclass that would allow me to factor quite a bit of > > redundant code. > >=20 > > =E2=80=A6 > > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then =20 >=20 > It=E2=80=99s always been recommended to me that we should use the [[ =E2= =80=A6 ]] > form. Doesn't make much difference here and I've always been recommending the other way :p (the idea is that you don't get to write the [[ ]] in a /bin/sh script just because you're used to it; if you only do ebuilds or bash, then you don't care, but I definitely do other scripts)