public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Aaron W. Swenson" <titanofold@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] New eclass: opam.eclass
Date: Mon, 24 Jul 2017 18:11:39 -0400	[thread overview]
Message-ID: <20170724221139.GC15937@gengoff> (raw)
In-Reply-To: <20170724172032.0a6623dc@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

On 2017-07-24 17:20, Alexis Ballier wrote:
> Hey,
> 
> Here is an eclass that would allow me to factor quite a bit of
> redundant code.
> 
> …
> 	if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then

It’s always been recommended to me that we should use the [[ … ]] form.

Otherwise, looks good to me.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 376 bytes --]

  reply	other threads:[~2017-07-24 22:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 15:20 [gentoo-dev] New eclass: opam.eclass Alexis Ballier
2017-07-24 22:11 ` Aaron W. Swenson [this message]
2017-07-25  8:25   ` Alexis Ballier
2017-07-25 12:48     ` Peter Stuge
2017-07-25 13:37       ` Michał Górny
2017-07-25 14:18 ` Michał Górny
2017-08-02 10:09   ` Alexis Ballier
2017-08-02 10:27     ` Alexis Ballier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170724221139.GC15937@gengoff \
    --to=titanofold@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox