From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D4812139694 for ; Thu, 29 Jun 2017 21:52:48 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E596DE085E; Thu, 29 Jun 2017 21:52:37 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 83905E0829 for ; Thu, 29 Jun 2017 21:52:37 +0000 (UTC) Received: from symphony.aura-online.co.uk (154.189.187.81.in-addr.arpa [81.187.189.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: chewi) by smtp.gentoo.org (Postfix) with ESMTPSA id 046483416F7 for ; Thu, 29 Jun 2017 21:52:35 +0000 (UTC) Date: Thu, 29 Jun 2017 22:52:24 +0100 From: James Le Cuirot To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] Profile-enforced big-endian USE flag Message-ID: <20170629225214.62b06923@symphony.aura-online.co.uk> In-Reply-To: References: <20170627234459.5bcb0d1b@symphony.aura-online.co.uk> <20170628232903.0230bc8e@symphony.aura-online.co.uk> <20170629221958.06c68bae@symphony.aura-online.co.uk> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/poJ3T=YZzvxfEl+FAeiQoV."; protocol="application/pgp-signature" X-Archives-Salt: 40d4d088-ee5f-4296-9a73-f32385349070 X-Archives-Hash: ce185ef8a0b5b87e487f92c6aec1055c --Sig_/poJ3T=YZzvxfEl+FAeiQoV. Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 29 Jun 2017 14:37:49 -0700 Matt Turner wrote: > On Thu, Jun 29, 2017 at 2:19 PM, James Le Cuirot wrote: > > On Wed, 28 Jun 2017 23:29:03 +0100 > > James Le Cuirot wrote: > > =20 > >> > On Tue, Jun 27, 2017 at 6:44 PM, James Le Cuirot = wrote: =20 > >> > > I am therefore proposing a new global big-endian flag. This could = be > >> > > masked by default and unmasked + forced in the relevant profiles u= nder > >> > > arch. I will apply this according to the mapping defined in tc-end= ian of > >> > > toolchain-funcs.eclass. =20 > >> > >> I've just been putting the patch together. I made it slightly simpler > >> by masking *and* forcing it by default so that it only needs to be > >> unmasked were necessary. =20 > > > > Feedback seems positive so here is the patch. I'll apply it late next > > week as I don't need it immediately and I will be away until then. > > > > --- > > > > diff --git a/profiles/arch/alpha/use.mask b/profiles/arch/alpha/use.mask > > index d488fe8a09f4..b17afe9d9d4d 100644 > > --- a/profiles/arch/alpha/use.mask > > +++ b/profiles/arch/alpha/use.mask > > @@ -1,6 +1,10 @@ > > # Copyright 1999-2017 Gentoo Foundation. > > # Distributed under the terms of the GNU General Public License, v2 > > > > +# James Le Cuirot (29 Jun 2017) > > +# Unmask as this profile is big endian. > > +-big-endian =20 >=20 > No. Alpha is little endian. Wikipedia says it is bi. tc-native() reports alpha* as big so I guess that's the only variant we support? Then again, this page says it is usually little. Is tc-native() wrong? https://kernelnewbies.org/EndianIssues > > --- /dev/null > > +++ b/profiles/arch/mips/mipsel/use.mask > > @@ -0,0 +1,6 @@ > > +# Copyright 1999-2017 Gentoo Foundation > > +# Distributed under the terms of the GNU General Public License v2 > > + > > +# James Le Cuirot (29 Jun 2017) > > +# Remask as this profile is little endian. > > +big-endian > > diff --git a/profiles/arch/mips/use.mask b/profiles/arch/mips/use.mask > > index 09ac8ca4b2cc..6caff81617cb 100644 > > --- a/profiles/arch/mips/use.mask > > +++ b/profiles/arch/mips/use.mask > > @@ -4,6 +4,10 @@ > > # Unmask the flag which corresponds to ARCH. > > -mips > > > > +# James Le Cuirot (29 Jun 2017) > > +# Unmask as this profile is big endian. > > +-big-endian =20 >=20 > I'm not sure if this one is correct. arch/mips/mipsel's 'parent' file > contains '..' >=20 > I think if you re-mask big-endian in arch/mips/mipsel it'll work, and > that seems like the best way to solve it. That's what I did? --Sig_/poJ3T=YZzvxfEl+FAeiQoV. Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQKTBAEBCgB9FiEEUo3mvYaRpDkf2i7UIcYyEpxtfeQFAllVdphfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDUy OERFNkJEODY5MUE0MzkxRkRBMkVENDIxQzYzMjEyOUM2RDdERTQACgkQIcYyEpxt feSvmA//Vb5ZAfq8u9XVm5X7hNeGPUZXKyAOt4O/zgILgYLEOwqxi/Y/SASRmtBV ifiw9j6qu9XRQc8JSUhXbVKJ7ySoOaWzAOaIAqMS8C/9xEgo+g2VmE9LNGM24ejG lmyK+QToDYwDHEGRaVLqZ64KD00sPTE+4HpuO7uKBtBFhvHmWA6kacaHVnR+LWQ3 6YaIPhM+PXQ/uRGCRfaIBOHuWUwN8UnhsAD1ORUdxkKoYw++B/URVkHpJQLBFLbL 9qy0X55ezkyhJxCK2+3OghqHtxAb4dSOCfshlfpfvABxLvv0Y8l7fYYD9rqQBeBa fWMQPEFa+4oSyn/od7v1j9H769wv1GFoRLYBaA0YTfm5qgm1gJyM9dwrn4MCjVof U9K+JJQp9nRyxP3bdkUVDQMJR6+N0bkyPFEKqTr8K2g0ywXH3XAKm3wDYilp63Tu xK7tJfzMI52jNmcuKaoUTjNMiZnGSMUL24FahUK3T4hQNpVvlPJNy2KTc2ZA1q8W +4VaujSe5d+KIa6jyH4+GMNn4Hcdgtp5+PqJzyh5eKTmlPkZzwj1ctBjrHosDQtx wNIGYRN16jOg5NBrIdo6QLdBrdUXu/5dcIa+Da8Mlpr2mvVQFWpi5Dsh+HCySi6k 46qsWEo9r5gyj7X2xxxjvd9ALNwJOryAt3BSBvu9cfZXFyWaH48= =WPD+ -----END PGP SIGNATURE----- --Sig_/poJ3T=YZzvxfEl+FAeiQoV.--