From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E3192139694 for ; Wed, 10 May 2017 21:15:25 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 056AF21C1C8; Wed, 10 May 2017 21:15:17 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A357221C127 for ; Wed, 10 May 2017 21:15:16 +0000 (UTC) Received: from patrickm (unknown [100.42.98.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: chutzpah) by smtp.gentoo.org (Postfix) with ESMTPSA id 69F7933FE74; Wed, 10 May 2017 21:15:15 +0000 (UTC) Date: Wed, 10 May 2017 14:15:06 -0700 From: Patrick McLean To: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Cc: gentoo-dev@lists.gentoo.org, python@gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/3] python-utils-r1.eclass: Allow -2/-3 as impl-patterns for py2/py3 Message-ID: <20170510141506.2e40093b@patrickm> In-Reply-To: <20170510185333.6423-1-mgorny@gentoo.org> References: <20170510185333.6423-1-mgorny@gentoo.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: aaf01824-2b49-476b-8914-90892e7e4623 X-Archives-Hash: bd1149e52191cd552ca1fa808a12f4c5 On Wed, 10 May 2017 20:53:31 +0200 Micha=C5=82 G=C3=B3rny wrote: > Allow two special values in the implementation patterns for > _python_impl_matches(): -2 to indicate all Python 2-compatible > implementations, and -3 to indicate all Python 3-compatible > implementations. Both of those values are implemented using > the python_is_python3 function. Seems mostly reasonable, though the syntax is somewhat confusing at first glance. There are many places where we use "-value" to negate, so this looks like it means "not python 2" rather than "all python 2". Perhaps something like '+2' would make it easier to read. > This is mostly meant to make it easier and more fool-proof to write > dependencies on backports to Python 2 which in most cases apply to > PyPy2 as well.