From: Patrick McLean <chutzpah@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, python@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/3] python-utils-r1.eclass: Allow -2/-3 as impl-patterns for py2/py3
Date: Wed, 10 May 2017 14:15:06 -0700 [thread overview]
Message-ID: <20170510141506.2e40093b@patrickm> (raw)
In-Reply-To: <20170510185333.6423-1-mgorny@gentoo.org>
On Wed, 10 May 2017 20:53:31 +0200
Michał Górny <mgorny@gentoo.org> wrote:
> Allow two special values in the implementation patterns for
> _python_impl_matches(): -2 to indicate all Python 2-compatible
> implementations, and -3 to indicate all Python 3-compatible
> implementations. Both of those values are implemented using
> the python_is_python3 function.
Seems mostly reasonable, though the syntax is somewhat confusing at
first glance. There are many places where we use "-value" to negate, so
this looks like it means "not python 2" rather than "all python 2".
Perhaps something like '+2' would make it easier to read.
> This is mostly meant to make it easier and more fool-proof to write
> dependencies on backports to Python 2 which in most cases apply to
> PyPy2 as well.
next prev parent reply other threads:[~2017-05-10 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 18:53 [gentoo-dev] [PATCH 1/3] python-utils-r1.eclass: Allow -2/-3 as impl-patterns for py2/py3 Michał Górny
2017-05-10 18:53 ` [gentoo-dev] [PATCH 2/3] virtual/python-futures: Use -2 operator to python_gen_usedep (example) Michał Górny
2017-05-10 18:53 ` [gentoo-dev] [PATCH 3/3] virtual/python-dnspython: Use -2/-3 operators " Michał Górny
2017-05-10 20:32 ` [gentoo-dev] Re: [PATCH 1/3] python-utils-r1.eclass: Allow -2/-3 as impl-patterns for py2/py3 Mike Gilbert
2017-05-10 21:15 ` Patrick McLean [this message]
2017-05-10 21:36 ` [gentoo-dev] " Michał Górny
2017-05-16 17:20 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510141506.2e40093b@patrickm \
--to=chutzpah@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
--cc=python@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox