From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3A98C139694 for ; Sat, 29 Apr 2017 18:04:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 07F21E0CFD; Sat, 29 Apr 2017 18:04:22 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id ADCD4E0BC2 for ; Sat, 29 Apr 2017 18:04:21 +0000 (UTC) Received: from katipo2.lan (unknown [203.86.205.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kentnl) by smtp.gentoo.org (Postfix) with ESMTPSA id DC7A633BEBE for ; Sat, 29 Apr 2017 18:04:19 +0000 (UTC) Date: Sun, 30 Apr 2017 06:03:49 +1200 From: Kent Fredric To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET Message-ID: <20170430060303.7036f085@katipo2.lan> In-Reply-To: <20170428143945.16032-1-mgorny@gentoo.org> References: <20170428143945.16032-1-mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/UrlEBump0gqNN73JVZ1xw2o"; protocol="application/pgp-signature" X-Archives-Salt: 24d10ac5-bea8-4448-994c-a45a0e34753d X-Archives-Hash: ade67ee188f06c8aa30ba62d4dab4f65 --Sig_/UrlEBump0gqNN73JVZ1xw2o Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 28 Apr 2017 16:39:45 +0200 Micha=C5=82 G=C3=B3rny wrote: > Change the unset value tag to '@DEFAULT-UNSET' to ensure consistent > use of hyphen/underscore throughout eclassdoc. Before, one tag > (@ECLASS-VARIABLE) has used hyphen while also one (@DEFAULT_UNSET) > used underscore. Unify them to use the former since @ECLASS-VARIABLE > tag is more common (and hyphens do not require holding shift). >=20 > Fixing all existing uses is perfectly within our power; however, I > think it would be reasonable to delay it and combine with other > eclass changes to avoid unnecessary cache regen. The script still > allows the old tag name for compatibility. I have a counter suggestion: 1. Leave @ECLASS-VARIABLE as-is 2. Leave @DEFAULT_UNSET as is 3. Document that underscores are to be used for all new tags 4. Add support for @ECLASS_VARIABLE that works the same as @ECLASS-VARIABLE 5. Don't go out of our way to migrate to @ECLASS_VARIABLE, just let it occur over time, particularly in conjunction with other major changes. Mostly because @FOO_VARIABLE is suspiciously similar syntax to me as other ALL CAPS variables used as ENV tokens in Bash. And I can't think of a single instance where I've seen a language with a convention that used ALL CAPS terms in conjunctions with hyphens, ( and regex with _ are ultimately simpler to reason about than ones with - ) --Sig_/UrlEBump0gqNN73JVZ1xw2o Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEPZazbI/qrFT1o9rn6FQySxNmqCAFAlkE1ZYACgkQ6FQySxNm qCB2DRAA0h6iZZ8USbmZWVe6Ilxgw6DkdbNycM+Sn7VSva44FmRE+UXNO4Afrj00 7Fjg02gZ2QGIjWd/hJFE3tx/NXTz9XUlBaaWBozhANfCnIzZaNpqw0bnUUteUQ3e 1sUxGntMybA1/qZrSyCLjhRTZHNzLvRa9P1Th2TwlBwMyBgfG8YBL28+SyKGeThX EdSdWOgpuiNxgqfseHP+VtvHBP7OPKBecKIHWU2MQaGrd9PoDaKDNlyqBz2HNxTs XlJoHThs5ZcyafbUyydF6u/kIXFcqZokx5zo7wk99tdSkjmhkEB8qyC1fG/s60sK hJpwuawM5dglrGtPOiq627F6Ykv01Lbs35ZIF8v2Q5Jg87DCFLmY8g9eGhrpvDyy eQumExe4w5qUyF7d+SZZFCzkN+ETo9DL1uO4q4ks7n8tXlxUtCUV3hXlrQt8QeQw 4x0JwIMSzBNtx62XYqLj8VlGBpz9NhcERkZ+B+ShuXD8bxmqDq3KS+p+5NV1b+qj MmEUB+bl6GZWsSyyblyGIt4D25sQOBnOYzDIq6R/6hlBtzpi6Polhbf9+y68ho4i ZadlceepIlaXZa2ueLtPA2M1VrMbQaH+l63XuN2R7kDbIgnyub8j38tHi/9X3FbT IXUF+dKx8a+w60cWpOFl6swmLYu65gTS7cqCoz/vHZji6AwjA0U= =AajX -----END PGP SIGNATURE----- --Sig_/UrlEBump0gqNN73JVZ1xw2o--