From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 72498139694 for ; Fri, 28 Apr 2017 14:40:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A9459E0E10; Fri, 28 Apr 2017 14:39:55 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 63152E0DF7 for ; Fri, 28 Apr 2017 14:39:55 +0000 (UTC) Received: from localhost.localdomain (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 24EF7341736; Fri, 28 Apr 2017 14:39:52 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: vapier@gentoo.org, tools-portage@gentoo.org, =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET Date: Fri, 28 Apr 2017 16:39:45 +0200 Message-Id: <20170428143945.16032-1-mgorny@gentoo.org> X-Mailer: git-send-email 2.13.0.rc1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Archives-Salt: e8caf13b-d037-4ac0-893d-a36bff353539 X-Archives-Hash: 2114bba5fd7b9b6a319f9943dcb6d25c Change the unset value tag to '@DEFAULT-UNSET' to ensure consistent use of hyphen/underscore throughout eclassdoc. Before, one tag (@ECLASS-VARIABLE) has used hyphen while also one (@DEFAULT_UNSET) used underscore. Unify them to use the former since @ECLASS-VARIABLE tag is more common (and hyphens do not require holding shift). Fixing all existing uses is perfectly within our power; however, I think it would be reasonable to delay it and combine with other eclass changes to avoid unnecessary cache regen. The script still allows the old tag name for compatibility. --- app-portage/eclass-manpages/files/eclass-to-manpage.awk | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/app-portage/eclass-manpages/files/eclass-to-manpage.awk b/app-portage/eclass-manpages/files/eclass-to-manpage.awk index 0b65162c04ec..8ff9f71a2022 100644 --- a/app-portage/eclass-manpages/files/eclass-to-manpage.awk +++ b/app-portage/eclass-manpages/files/eclass-to-manpage.awk @@ -36,7 +36,7 @@ # The format of function-specific variables: # @VARIABLE: foo -# [@DEFAULT_UNSET] +# [@DEFAULT-UNSET] # [@INTERNAL] # [@REQUIRED] # @DESCRIPTION: @@ -45,7 +45,7 @@ # The format of eclass variables: # @ECLASS-VARIABLE: foo -# [@DEFAULT_UNSET] +# [@DEFAULT-UNSET] # [@INTERNAL] # [@REQUIRED] # @DESCRIPTION: @@ -284,9 +284,12 @@ function _handle_variable() { opts = 1 while (opts) { getline - if ($2 == "@DEFAULT_UNSET") + if ($2 == "@DEFAULT-UNSET") default_unset = 1 - else if ($2 == "@INTERNAL") + else if ($2 == "@DEFAULT_UNSET") { + warn(var_name ": use @DEFAULT-UNSET instead of @DEFAULT_UNSET") + default_unset = 1 + } else if ($2 == "@INTERNAL") internal = 1 else if ($2 == "@REQUIRED") required = 1 -- 2.13.0.rc1