From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 67AA3139694 for ; Sat, 22 Apr 2017 17:53:36 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E520021C0A6; Sat, 22 Apr 2017 17:53:27 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 97F5421C09E for ; Sat, 22 Apr 2017 17:53:27 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e34:eeaa:6bd0:4ecc:6aff:fe03:1cfc]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id 2BD6034071C for ; Sat, 22 Apr 2017 17:53:26 +0000 (UTC) Date: Sat, 22 Apr 2017 19:53:15 +0200 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] gnome2-utils.eclass: gnome2_query_immodules*, use EROOT, #611030 Message-ID: <20170422195315.46135317@gentoo.org> In-Reply-To: References: <20170422082058.19281-1-mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: d87329b4-b9f9-4994-8c91-2356a85bd626 X-Archives-Hash: 0ed78eaf2069b3379eac0ae0e089d2e8 On Sat, 22 Apr 2017 13:43:21 -0400 Mike Gilbert wrote: > On Sat, Apr 22, 2017 at 4:20 AM, Micha=C5=82 G=C3=B3rny > wrote: > > Respect EROOT when running gtk-query-immodules-* tools, alike other > > updaters in the eclass. This ensures that x11-libs/gtk+ installs > > correctly when installing to a ROOT. =20 >=20 > I'm not an expert on this eclass, but it seems like this may be > intentional; calling compiled binaries from $ROOT will break for > cross-compiles. yes, I think calling binaries from EROOT is wrong; it should call binaries from EPREFIX with arguments in EROOT; it's likely the other functions in the eclass are wrong on that