From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] gnome2-utils.eclass: gnome2_query_immodules*, use EROOT, #611030
Date: Sat, 22 Apr 2017 19:53:15 +0200 [thread overview]
Message-ID: <20170422195315.46135317@gentoo.org> (raw)
In-Reply-To: <CAJ0EP41pg1iB4kjq+LjeP=PjQaBqzTgoV-dKTt8ZmYTosfc2wQ@mail.gmail.com>
On Sat, 22 Apr 2017 13:43:21 -0400
Mike Gilbert <floppym@gentoo.org> wrote:
> On Sat, Apr 22, 2017 at 4:20 AM, Michał Górny <mgorny@gentoo.org>
> wrote:
> > Respect EROOT when running gtk-query-immodules-* tools, alike other
> > updaters in the eclass. This ensures that x11-libs/gtk+ installs
> > correctly when installing to a ROOT.
>
> I'm not an expert on this eclass, but it seems like this may be
> intentional; calling compiled binaries from $ROOT will break for
> cross-compiles.
yes, I think calling binaries from EROOT is wrong; it should call
binaries from EPREFIX with arguments in EROOT; it's likely the other
functions in the eclass are wrong on that
next prev parent reply other threads:[~2017-04-22 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 8:20 [gentoo-dev] [PATCH] gnome2-utils.eclass: gnome2_query_immodules*, use EROOT, #611030 Michał Górny
2017-04-22 17:43 ` Mike Gilbert
2017-04-22 17:48 ` Mike Gilbert
2017-04-22 17:53 ` Alexis Ballier [this message]
2017-04-22 21:03 ` Michał Górny
2017-04-25 11:41 ` Gilles Dartiguelongue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170422195315.46135317@gentoo.org \
--to=aballier@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox