From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C3D6E139694 for ; Thu, 23 Mar 2017 21:38:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D9D1E21C16C; Thu, 23 Mar 2017 21:37:56 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9082321C091 for ; Thu, 23 Mar 2017 21:37:56 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e34:eeaa:6bd0:4ecc:6aff:fe03:1cfc]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id 11FE1341657 for ; Thu, 23 Mar 2017 21:37:54 +0000 (UTC) Date: Thu, 23 Mar 2017 22:37:49 +0100 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [PATCH] sys-devel/autoconf: Convert from eblits into an eclass, #586424 Message-ID: <20170323223749.71de6c09@gentoo.org> In-Reply-To: <20170323203040.598f6278@snowblower> References: <20170316093806.31977-1-mgorny@gentoo.org> <20170320083544.GZ24205@vapier> <2240597.YoP4Ev77Vx@porto> <1652433.oqbzW57v8l@porto> <20170323105101.0f622f66@gentoo.org> <1490288005.1534.1.camel@gentoo.org> <20170323195213.406ba9f8@gentoo.org> <1490295612.1534.3.camel@gentoo.org> <20170323212254.1bb17f3d@gentoo.org> <20170323203040.598f6278@snowblower> Organization: Gentoo X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 01886f37-4f09-4419-8bec-003253391321 X-Archives-Hash: f8bcaba81101f6bdc06e7d9b37922077 On Thu, 23 Mar 2017 20:30:40 +0000 Ciaran McCreesh wrote: > On Thu, 23 Mar 2017 21:22:54 +0100 > Alexis Ballier wrote: > > Indeed, according to pms.git commit log, the rule was laxed because > > it was clearly an oversight in EAPI6 [1] and was the standard > > behavior in previous EAPIs. But in the same commit, an "harmless > > note" was added that "Ebuilds must not access the directory in > > global scope." in addition to the "May or may not exist" statement > > and "Not necessarily present when installing from a binary package" > > footnote. Please explain how this last addition is not a > > backwards-breaking change. PMS is not a tool to push your personal > > agenda of cleaning up the deve^^err tree. > > The original wording should probably have been something like "may or > may not exist, so ebuilds MUST NOT go poking around for it", but the > original wording was written assuming reasonable behaviour from > developers, and we deliberately chose not to go the SHALL, MUST NOT > route because of the added cost of developing a specification that's > safe from hostile implementers. > "reasonable" is not something that can be reasonably defined :) after a few dozens of emails, what i understand of the issue is: autoconf assumes either the eblit stuff is in the environment, or FILESDIR variable is empty or points to its files dir; this might be borderline but definitely not hostile. this breaks in the (hypothetical?) case where the package is installed from a binpkg *and* the binpkg format does not include the whole environment but rather a verbatim copy of the ebuild and its eclasses(*). if that's the buggy case, then it should definitely have been stated upfront on the bug and it would likely have been fixed long ago; failing that it just seems to be un-necessary nitpicking over a different interpretation of some wording (*) not sure how that can even work with env saving between phases but that's not the point