From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-80049-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 7FC9B139694
	for <garchives@archives.gentoo.org>; Thu, 23 Mar 2017 18:41:22 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id DBDF721C132;
	Thu, 23 Mar 2017 18:41:09 +0000 (UTC)
Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 97B2121C0AA
	for <gentoo-dev@lists.gentoo.org>; Thu, 23 Mar 2017 18:41:09 +0000 (UTC)
Received: from localhost (unknown [IPv6:2a01:e34:eeaa:6bd0:4ecc:6aff:fe03:1cfc])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: aballier)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 8A805341645
	for <gentoo-dev@lists.gentoo.org>; Thu, 23 Mar 2017 18:41:07 +0000 (UTC)
Date: Thu, 23 Mar 2017 19:41:01 +0100
From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [PATCH] sys-devel/autoconf: Convert from
 eblits into an eclass, #586424
Message-ID: <20170323194101.0e6af3c2@gentoo.org>
In-Reply-To: <eada7195-7d24-2e33-8702-7ef4f679cd01@gentoo.org>
References: <20170316093806.31977-1-mgorny@gentoo.org>
	<1652433.oqbzW57v8l@porto>
	<20170323105101.0f622f66@gentoo.org>
	<3173924.ULbGtHHRMq@porto>
	<20170323143659.3c882568@gentoo.org>
	<eada7195-7d24-2e33-8702-7ef4f679cd01@gentoo.org>
Organization: Gentoo
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Archives-Salt: 71041509-b6d3-4664-9457-af2fcd5b3364
X-Archives-Hash: 44540b8b377d04e9c698f25333ab283e

On Thu, 23 Mar 2017 12:36:24 -0400
Michael Orlitzky <mjo@gentoo.org> wrote:

> On 03/23/2017 09:36 AM, Alexis Ballier wrote:
> >>
> >> No, the argument is about "we want to clean up the tree from
> >> abusive hacks".  
> >
> > This is yours. Mike's answer is merely asking for proper
> > justification and doesn't seem to have had an answer yet.
> >  
> 
> The PMS[0] says
> 
>    Ebuilds must not access [FILESDIR] in global scope.
> 
> But, for example, autoconf-2.69-r2.ebuild does,
> 
>    if [[ -z ${__EBLITS__} && -n ${FILESDIR} ]] ; then
>      source "${FILESDIR}"/eblits/main.eblit || die
>    fi
> 
> in global scope.
> 

Continuing to be the devil's advocate, it seems adding '&& -d
${FILESDIR}' to that if would fix the issue too. At least with all
currently approved EAPIs.


About the part you quote, please see:
https://gitweb.gentoo.org/proj/pms.git/commit/?id=22a0ce7c0fe649572956f60d13e1003ced401689

This is arguably a backwards-breaking change in PMS that appeared after
the last EAPI was approved, so I definitely understand the need for a
better explanation here. Prior to that change, the only rule was that
ebuilds must not assume the directory exists except in src_* phases.

Alexis.