From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 832A4139694 for ; Thu, 23 Mar 2017 18:46:49 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3469821C1EA; Thu, 23 Mar 2017 18:46:42 +0000 (UTC) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BE37A21C091 for ; Thu, 23 Mar 2017 18:46:41 +0000 (UTC) Received: by mail-wm0-x229.google.com with SMTP id u132so69177333wmg.0 for ; Thu, 23 Mar 2017 11:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=4NZMp1L2DcAySBw3UH4VTz/VnbktwSyIdordjnWStJ4=; b=AgiGMz5ix3VrDjZ3+6p+EQTzG1sCdcMNlmpFLT/nrsiiJL1G5Jl1UXYHUTa2gXFq59 mAIn4e+paKwKZRdArHca+Eaxb9WDBDRCkeSGfRQRVnzPBgDtQjOvEqdQjMg9lBoolw0b LKecm6GRNNXWLTqUy9U5OMGv4HXQXpBrvevlj8U90Ywg+yQbzR3oPA8DE8O2Tcb9/WQP YhRQXHPZl7hUh9dVXxNrFDPScmxMMBm9LkdkRuXMt8/VxEaiDuOOXFINH/+7EvPIk251 BK1BlbaJy7YThQM3NjZGQ18Eup6wTiveR6FzYeJJB+WiFX7TdwQnJ8Rr5MZXQPrAUzDY vY4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4NZMp1L2DcAySBw3UH4VTz/VnbktwSyIdordjnWStJ4=; b=id3GXWObFRP6S6+HOZDeL8+u0jOf9fVf4f8iWgTtU9b7iU4udO//q32xulPPlUCfke ZsOQV6CDF9T1MLMEL4EIcBOiNSQByKTjFeNgyNsRlK1eZlqZnHzqXCtMWEuHIJ8vFGtn mubnWsXN1hDhU75R50Q0oPNC0EuwIMZm11b8ibYZADwZUSx8ehInJCdX4ReI+cgXKR+7 znmrtV8HVoLqznFWhaMIDBLEJvSH/m2UKrQEmtdOo8r2JMlGY2dm2ToXDj+NO4uJ7h+v QuIdUXLVRz7s0Bke2nMc67s658qwm3n9soapraE+SxtxKgZCz8J41DG60dwNt4x5EHNf fq8A== X-Gm-Message-State: AFeK/H2KaFsinnx/JjxN0eLwUMs3z9aMvaFYe0cgarnk3AZ9Pw2lLe/9tLTjjv3tbwGfiA== X-Received: by 10.28.98.135 with SMTP id w129mr601684wmb.68.1490294800220; Thu, 23 Mar 2017 11:46:40 -0700 (PDT) Received: from snowblower (cpc14-broo7-2-0-cust7.14-2.cable.virginm.net. [82.0.20.8]) by smtp.gmail.com with ESMTPSA id u7sm6911327wru.56.2017.03.23.11.46.39 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Mar 2017 11:46:39 -0700 (PDT) Date: Thu, 23 Mar 2017 18:46:35 +0000 From: Ciaran McCreesh To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [PATCH] sys-devel/autoconf: Convert from eblits into an eclass, #586424 Message-ID: <20170323184635.3233779f@snowblower> In-Reply-To: <20170323194101.0e6af3c2@gentoo.org> References: <20170316093806.31977-1-mgorny@gentoo.org> <1652433.oqbzW57v8l@porto> <20170323105101.0f622f66@gentoo.org> <3173924.ULbGtHHRMq@porto> <20170323143659.3c882568@gentoo.org> <20170323194101.0e6af3c2@gentoo.org> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 9e940241-8682-42e1-84be-2478270b9329 X-Archives-Hash: d46ee56c6ff9f3a8f98fc8b3f9038704 On Thu, 23 Mar 2017 19:41:01 +0100 Alexis Ballier wrote: > > The PMS[0] says > > > > Ebuilds must not access [FILESDIR] in global scope. > > > > But, for example, autoconf-2.69-r2.ebuild does, > > > > if [[ -z ${__EBLITS__} && -n ${FILESDIR} ]] ; then > > source "${FILESDIR}"/eblits/main.eblit || die > > fi > > > > in global scope. > > > > Continuing to be the devil's advocate, it seems adding '&& -d > ${FILESDIR}' to that if would fix the issue too. At least with all > currently approved EAPIs. Please stop. PMS was not written with the kind of resources needed to deal with people deliberately trying to find loopholes. -- Ciaran McCreesh