From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 56DFA139694 for ; Mon, 20 Mar 2017 22:56:25 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EA46F21C260; Mon, 20 Mar 2017 22:56:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 904DB21C25A for ; Mon, 20 Mar 2017 22:56:00 +0000 (UTC) Received: from sf (host81-129-87-182.range81-129.btcentralplus.com [81.129.87.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: slyfox) by smtp.gentoo.org (Postfix) with ESMTPSA id BACAE340AC7; Mon, 20 Mar 2017 22:55:58 +0000 (UTC) Date: Mon, 20 Mar 2017 22:55:54 +0000 From: Sergei Trofimovich To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= , base-system@gentoo.org Subject: Re: [gentoo-dev] [PATCH 2/2] sys-libs/ncurses: Remove parallel econf logic Message-ID: <20170320225554.6b938166@sf> In-Reply-To: <20170320193552.32500-2-mgorny@gentoo.org> References: <20170320193552.32500-1-mgorny@gentoo.org> <20170320193552.32500-2-mgorny@gentoo.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/8=pjN1+.Y.o+acRdEAR78OW"; protocol="application/pgp-signature" X-Archives-Salt: d51c90dc-43b6-472e-9ce6-139d9750e055 X-Archives-Hash: d779bf776b208f2e2e30adcaa1d2f5eb --Sig_/8=pjN1+.Y.o+acRdEAR78OW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 20 Mar 2017 20:35:52 +0100 Micha=C5=82 G=C3=B3rny wrote: CCing maintainer > Remove the parallel econf logic that adds a lot of complexity for minor > gain. It results in the output from different configure scripts being > mixed in the build log, making it unreadable. It causes econf to be run > in a subshell which is a PMS violation and can cause issues with some of > package manager implementations. Furthermore, the multijob parallel > processes are interleaved with multilib-build logic which is unsupported > and a very bad idea. > --- > sys-libs/ncurses/ncurses-5.9-r101.ebuild | 11 ++++------- > sys-libs/ncurses/ncurses-6.0-r1.ebuild | 9 +++------ > 2 files changed, 7 insertions(+), 13 deletions(-) >=20 > diff --git a/sys-libs/ncurses/ncurses-5.9-r101.ebuild b/sys-libs/ncurses/= ncurses-5.9-r101.ebuild > index 76b8a76d3a72..c722d68f3208 100644 > --- a/sys-libs/ncurses/ncurses-5.9-r101.ebuild > +++ b/sys-libs/ncurses/ncurses-5.9-r101.ebuild > @@ -1,11 +1,11 @@ > -# Copyright 1999-2015 Gentoo Foundation > +# Copyright 1999-2017 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > =20 > # This version is just for the ABI .5 library > =20 > EAPI=3D"5" > =20 > -inherit eutils toolchain-funcs multilib-minimal multiprocessing > +inherit eutils toolchain-funcs multilib-minimal > =20 > MY_PV=3D${PV:0:3} > MY_P=3D${PN}-${MY_PV} > @@ -55,8 +55,6 @@ src_configure() { > $(usex unicode 'ncursesw' '') > ) > =20 > - multijob_init > - > # When installing ncurses, we have to use a compatible version of tic. > # This comes up when cross-compiling, doing multilib builds, upgrading, > # or installing for the first time. Build a local copy of tic whenever > @@ -69,16 +67,15 @@ src_configure() { > CXXFLAGS=3D${BUILD_CXXFLAGS} \ > CPPFLAGS=3D${BUILD_CPPFLAGS} \ > LDFLAGS=3D"${BUILD_LDFLAGS} -static" \ > - multijob_child_init do_configure cross --without-shared --with-normal > + do_configure cross --without-shared --with-normal > fi > multilib-minimal_src_configure > - multijob_finish > } > =20 > multilib_src_configure() { > local t > for t in "${NCURSES_TARGETS[@]}" ; do > - multijob_child_init do_configure "${t}" > + do_configure "${t}" > done > } > =20 > diff --git a/sys-libs/ncurses/ncurses-6.0-r1.ebuild b/sys-libs/ncurses/nc= urses-6.0-r1.ebuild > index 2ab63de41d4c..d98b23afb751 100644 > --- a/sys-libs/ncurses/ncurses-6.0-r1.ebuild > +++ b/sys-libs/ncurses/ncurses-6.0-r1.ebuild > @@ -3,7 +3,7 @@ > =20 > EAPI=3D"5" > =20 > -inherit eutils flag-o-matic toolchain-funcs multilib-minimal multiproces= sing > +inherit eutils flag-o-matic toolchain-funcs multilib-minimal > =20 > MY_PV=3D${PV:0:3} > PV_SNAP=3D${PV:4} > @@ -61,8 +61,6 @@ src_configure() { > $(use unicode && usex threads 'ncursestw' '') > ) > =20 > - multijob_init > - > # When installing ncurses, we have to use a compatible version of tic. > # This comes up when cross-compiling, doing multilib builds, upgrading, > # or installing for the first time. Build a local copy of tic whenever > @@ -87,16 +85,15 @@ src_configure() { > CXXFLAGS=3D${BUILD_CXXFLAGS} \ > CPPFLAGS=3D${BUILD_CPPFLAGS} \ > LDFLAGS=3D"${BUILD_LDFLAGS} ${lbuildflags}" \ > - multijob_child_init do_configure cross --without-shared --with-normal > + do_configure cross --without-shared --with-normal > fi > multilib-minimal_src_configure > - multijob_finish > } > =20 > multilib_src_configure() { > local t > for t in "${NCURSES_TARGETS[@]}" ; do > - multijob_child_init do_configure "${t}" > + do_configure "${t}" > done > } > =20 > --=20 > 2.12.0 >=20 >=20 --=20 Sergei --Sig_/8=pjN1+.Y.o+acRdEAR78OW Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSZKa0VG5avZRlY01hxoe52YR/zqgUCWNBd+gAKCRBxoe52YR/z qjCwAJ0YXDXLuO0UDNQivVhTJJ1+xaLGegCeJzMSqO/Ht+QNnOxMRSYNvps6EwI= =A86U -----END PGP SIGNATURE----- --Sig_/8=pjN1+.Y.o+acRdEAR78OW--