From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 784A5139694 for ; Mon, 20 Mar 2017 22:55:18 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6B4BA21C229; Mon, 20 Mar 2017 22:55:11 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0C62F21C054 for ; Mon, 20 Mar 2017 22:55:11 +0000 (UTC) Received: from sf (host81-129-87-182.range81-129.btcentralplus.com [81.129.87.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: slyfox) by smtp.gentoo.org (Postfix) with ESMTPSA id 28364340AC7; Mon, 20 Mar 2017 22:55:08 +0000 (UTC) Date: Mon, 20 Mar 2017 22:55:01 +0000 From: Sergei Trofimovich To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= , hwoarang@gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/2] dev-lang/jimtcl: Remove parallel econf code Message-ID: <20170320225501.1b614a97@sf> In-Reply-To: <20170320193552.32500-1-mgorny@gentoo.org> References: <20170320193552.32500-1-mgorny@gentoo.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/.ZDp8.FUH5gagH35p5w2C=8"; protocol="application/pgp-signature" X-Archives-Salt: 8a53d4ab-34d4-4d66-a6ba-bbbbc01ba141 X-Archives-Hash: 03a86c203dac2f8eee4dc4e1504a7ccb --Sig_/.ZDp8.FUH5gagH35p5w2C=8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 20 Mar 2017 20:35:51 +0100 Micha=C5=82 G=C3=B3rny wrote: CCing maintainer > The parallel econf code is used only with USE=3Dstatic-libs, and even in > that case provides negligible speed gain. At the same time, it adds > a lot of complexity, causes the build logs to be unreadable mix of > output from both configure scripts and violates PMS by calling econf > in parallel which can cause issues with different package managers. > --- > dev-lang/jimtcl/jimtcl-0.75-r1.ebuild | 10 ++++------ > dev-lang/jimtcl/jimtcl-0.76.ebuild | 10 ++++------ > dev-lang/jimtcl/jimtcl-9999.ebuild | 10 ++++------ > 3 files changed, 12 insertions(+), 18 deletions(-) >=20 > diff --git a/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild b/dev-lang/jimtcl/jimt= cl-0.75-r1.ebuild > index d05b5040644f..180745bbe7da 100644 > --- a/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild > +++ b/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild > @@ -1,9 +1,9 @@ > -# Copyright 1999-2014 Gentoo Foundation > +# Copyright 1999-2017 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > =20 > EAPI=3D"5" > =20 > -inherit multiprocessing eutils > +inherit eutils > =20 > if [[ ${PV} =3D=3D "9999" ]] ; then > EGIT_REPO_URI=3D"http://repo.or.cz/r/jimtcl.git" > @@ -40,15 +40,13 @@ src_prepare() { > } > =20 > src_configure() { > - multijob_init > - CCACHE=3DNone multijob_child_init econf --with-jim-shared > + CCACHE=3DNone econf --with-jim-shared > if use static-libs ; then > # The build does not support doing both simultaneously. > mkdir static-libs > cd static-libs > - CCACHE=3DNone ECONF_SOURCE=3D${S} multijob_child_init econf > + CCACHE=3DNone ECONF_SOURCE=3D${S} econf > fi > - multijob_finish > } > =20 > src_compile() { > diff --git a/dev-lang/jimtcl/jimtcl-0.76.ebuild b/dev-lang/jimtcl/jimtcl-= 0.76.ebuild > index a82e24c9b204..ecdcdc96fac5 100644 > --- a/dev-lang/jimtcl/jimtcl-0.76.ebuild > +++ b/dev-lang/jimtcl/jimtcl-0.76.ebuild > @@ -1,9 +1,9 @@ > -# Copyright 1999-2015 Gentoo Foundation > +# Copyright 1999-2017 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > =20 > EAPI=3D"5" > =20 > -inherit multiprocessing eutils > +inherit eutils > =20 > if [[ ${PV} =3D=3D "9999" ]] ; then > EGIT_REPO_URI=3D"http://repo.or.cz/r/jimtcl.git" > @@ -40,15 +40,13 @@ src_prepare() { > } > =20 > src_configure() { > - multijob_init > - CCACHE=3DNone multijob_child_init econf --with-jim-shared > + CCACHE=3DNone econf --with-jim-shared > if use static-libs ; then > # The build does not support doing both simultaneously. > mkdir static-libs > cd static-libs > - CCACHE=3DNone ECONF_SOURCE=3D${S} multijob_child_init econf > + CCACHE=3DNone ECONF_SOURCE=3D${S} econf > fi > - multijob_finish > } > =20 > src_compile() { > diff --git a/dev-lang/jimtcl/jimtcl-9999.ebuild b/dev-lang/jimtcl/jimtcl-= 9999.ebuild > index d05b5040644f..180745bbe7da 100644 > --- a/dev-lang/jimtcl/jimtcl-9999.ebuild > +++ b/dev-lang/jimtcl/jimtcl-9999.ebuild > @@ -1,9 +1,9 @@ > -# Copyright 1999-2014 Gentoo Foundation > +# Copyright 1999-2017 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > =20 > EAPI=3D"5" > =20 > -inherit multiprocessing eutils > +inherit eutils > =20 > if [[ ${PV} =3D=3D "9999" ]] ; then > EGIT_REPO_URI=3D"http://repo.or.cz/r/jimtcl.git" > @@ -40,15 +40,13 @@ src_prepare() { > } > =20 > src_configure() { > - multijob_init > - CCACHE=3DNone multijob_child_init econf --with-jim-shared > + CCACHE=3DNone econf --with-jim-shared > if use static-libs ; then > # The build does not support doing both simultaneously. > mkdir static-libs > cd static-libs > - CCACHE=3DNone ECONF_SOURCE=3D${S} multijob_child_init econf > + CCACHE=3DNone ECONF_SOURCE=3D${S} econf > fi > - multijob_finish > } > =20 > src_compile() { > --=20 > 2.12.0 >=20 >=20 --=20 Sergei --Sig_/.ZDp8.FUH5gagH35p5w2C=8 Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSZKa0VG5avZRlY01hxoe52YR/zqgUCWNBdxgAKCRBxoe52YR/z qtIJAJ99c1nxzVjCl8U7Oq/cfXF3ZBYI7ACfZUXW9IYgIx9SUYXxVcbnc5+x82k= =PjFW -----END PGP SIGNATURE----- --Sig_/.ZDp8.FUH5gagH35p5w2C=8--