Re: [gentoo-dev] [PATCH 1/2] dev-lang/jimtcl: Remove parallel econf code

[Sergei Trofimovich <slyfox@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 3943 bytes --]

On Mon, 20 Mar 2017 20:35:51 +0100
Michał Górny <mgorny@gentoo.org> wrote:

CCing maintainer

> The parallel econf code is used only with USE=static-libs, and even in
> that case provides negligible speed gain. At the same time, it adds
> a lot of complexity, causes the build logs to be unreadable mix of
> output from both configure scripts and violates PMS by calling econf
> in parallel which can cause issues with different package managers.
> ---
>  dev-lang/jimtcl/jimtcl-0.75-r1.ebuild | 10 ++++------
>  dev-lang/jimtcl/jimtcl-0.76.ebuild    | 10 ++++------
>  dev-lang/jimtcl/jimtcl-9999.ebuild    | 10 ++++------
>  3 files changed, 12 insertions(+), 18 deletions(-)
> 
> diff --git a/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild b/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild
> index d05b5040644f..180745bbe7da 100644
> --- a/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild
> +++ b/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild
> @@ -1,9 +1,9 @@
> -# Copyright 1999-2014 Gentoo Foundation
> +# Copyright 1999-2017 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
>  
>  EAPI="5"
>  
> -inherit multiprocessing eutils
> +inherit eutils
>  
>  if [[ ${PV} == "9999" ]] ; then
>  	EGIT_REPO_URI="http://repo.or.cz/r/jimtcl.git"
> @@ -40,15 +40,13 @@ src_prepare() {
>  }
>  
>  src_configure() {
> -	multijob_init
> -	CCACHE=None multijob_child_init econf --with-jim-shared
> +	CCACHE=None econf --with-jim-shared
>  	if use static-libs ; then
>  		# The build does not support doing both simultaneously.
>  		mkdir static-libs
>  		cd static-libs
> -		CCACHE=None ECONF_SOURCE=${S} multijob_child_init econf
> +		CCACHE=None ECONF_SOURCE=${S} econf
>  	fi
> -	multijob_finish
>  }
>  
>  src_compile() {
> diff --git a/dev-lang/jimtcl/jimtcl-0.76.ebuild b/dev-lang/jimtcl/jimtcl-0.76.ebuild
> index a82e24c9b204..ecdcdc96fac5 100644
> --- a/dev-lang/jimtcl/jimtcl-0.76.ebuild
> +++ b/dev-lang/jimtcl/jimtcl-0.76.ebuild
> @@ -1,9 +1,9 @@
> -# Copyright 1999-2015 Gentoo Foundation
> +# Copyright 1999-2017 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
>  
>  EAPI="5"
>  
> -inherit multiprocessing eutils
> +inherit eutils
>  
>  if [[ ${PV} == "9999" ]] ; then
>  	EGIT_REPO_URI="http://repo.or.cz/r/jimtcl.git"
> @@ -40,15 +40,13 @@ src_prepare() {
>  }
>  
>  src_configure() {
> -	multijob_init
> -	CCACHE=None multijob_child_init econf --with-jim-shared
> +	CCACHE=None econf --with-jim-shared
>  	if use static-libs ; then
>  		# The build does not support doing both simultaneously.
>  		mkdir static-libs
>  		cd static-libs
> -		CCACHE=None ECONF_SOURCE=${S} multijob_child_init econf
> +		CCACHE=None ECONF_SOURCE=${S} econf
>  	fi
> -	multijob_finish
>  }
>  
>  src_compile() {
> diff --git a/dev-lang/jimtcl/jimtcl-9999.ebuild b/dev-lang/jimtcl/jimtcl-9999.ebuild
> index d05b5040644f..180745bbe7da 100644
> --- a/dev-lang/jimtcl/jimtcl-9999.ebuild
> +++ b/dev-lang/jimtcl/jimtcl-9999.ebuild
> @@ -1,9 +1,9 @@
> -# Copyright 1999-2014 Gentoo Foundation
> +# Copyright 1999-2017 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
>  
>  EAPI="5"
>  
> -inherit multiprocessing eutils
> +inherit eutils
>  
>  if [[ ${PV} == "9999" ]] ; then
>  	EGIT_REPO_URI="http://repo.or.cz/r/jimtcl.git"
> @@ -40,15 +40,13 @@ src_prepare() {
>  }
>  
>  src_configure() {
> -	multijob_init
> -	CCACHE=None multijob_child_init econf --with-jim-shared
> +	CCACHE=None econf --with-jim-shared
>  	if use static-libs ; then
>  		# The build does not support doing both simultaneously.
>  		mkdir static-libs
>  		cd static-libs
> -		CCACHE=None ECONF_SOURCE=${S} multijob_child_init econf
> +		CCACHE=None ECONF_SOURCE=${S} econf
>  	fi
> -	multijob_finish
>  }
>  
>  src_compile() {
> -- 
> 2.12.0
> 
> 


-- 

  Sergei

[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]