From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1DEE1139694 for ; Mon, 20 Mar 2017 19:36:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0B48921C21E; Mon, 20 Mar 2017 19:36:08 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AB3ED21C1F6 for ; Mon, 20 Mar 2017 19:36:07 +0000 (UTC) Received: from localhost.localdomain (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id B98B533E142; Mon, 20 Mar 2017 19:36:05 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-dev] [PATCH 1/2] dev-lang/jimtcl: Remove parallel econf code Date: Mon, 20 Mar 2017 20:35:51 +0100 Message-Id: <20170320193552.32500-1-mgorny@gentoo.org> X-Mailer: git-send-email 2.12.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Archives-Salt: f0fdedce-d994-45e0-a3e2-040695d85c5d X-Archives-Hash: b09f1271e603e36084ff4e0b44147fda The parallel econf code is used only with USE=static-libs, and even in that case provides negligible speed gain. At the same time, it adds a lot of complexity, causes the build logs to be unreadable mix of output from both configure scripts and violates PMS by calling econf in parallel which can cause issues with different package managers. --- dev-lang/jimtcl/jimtcl-0.75-r1.ebuild | 10 ++++------ dev-lang/jimtcl/jimtcl-0.76.ebuild | 10 ++++------ dev-lang/jimtcl/jimtcl-9999.ebuild | 10 ++++------ 3 files changed, 12 insertions(+), 18 deletions(-) diff --git a/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild b/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild index d05b5040644f..180745bbe7da 100644 --- a/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild +++ b/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild @@ -1,9 +1,9 @@ -# Copyright 1999-2014 Gentoo Foundation +# Copyright 1999-2017 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 EAPI="5" -inherit multiprocessing eutils +inherit eutils if [[ ${PV} == "9999" ]] ; then EGIT_REPO_URI="http://repo.or.cz/r/jimtcl.git" @@ -40,15 +40,13 @@ src_prepare() { } src_configure() { - multijob_init - CCACHE=None multijob_child_init econf --with-jim-shared + CCACHE=None econf --with-jim-shared if use static-libs ; then # The build does not support doing both simultaneously. mkdir static-libs cd static-libs - CCACHE=None ECONF_SOURCE=${S} multijob_child_init econf + CCACHE=None ECONF_SOURCE=${S} econf fi - multijob_finish } src_compile() { diff --git a/dev-lang/jimtcl/jimtcl-0.76.ebuild b/dev-lang/jimtcl/jimtcl-0.76.ebuild index a82e24c9b204..ecdcdc96fac5 100644 --- a/dev-lang/jimtcl/jimtcl-0.76.ebuild +++ b/dev-lang/jimtcl/jimtcl-0.76.ebuild @@ -1,9 +1,9 @@ -# Copyright 1999-2015 Gentoo Foundation +# Copyright 1999-2017 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 EAPI="5" -inherit multiprocessing eutils +inherit eutils if [[ ${PV} == "9999" ]] ; then EGIT_REPO_URI="http://repo.or.cz/r/jimtcl.git" @@ -40,15 +40,13 @@ src_prepare() { } src_configure() { - multijob_init - CCACHE=None multijob_child_init econf --with-jim-shared + CCACHE=None econf --with-jim-shared if use static-libs ; then # The build does not support doing both simultaneously. mkdir static-libs cd static-libs - CCACHE=None ECONF_SOURCE=${S} multijob_child_init econf + CCACHE=None ECONF_SOURCE=${S} econf fi - multijob_finish } src_compile() { diff --git a/dev-lang/jimtcl/jimtcl-9999.ebuild b/dev-lang/jimtcl/jimtcl-9999.ebuild index d05b5040644f..180745bbe7da 100644 --- a/dev-lang/jimtcl/jimtcl-9999.ebuild +++ b/dev-lang/jimtcl/jimtcl-9999.ebuild @@ -1,9 +1,9 @@ -# Copyright 1999-2014 Gentoo Foundation +# Copyright 1999-2017 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 EAPI="5" -inherit multiprocessing eutils +inherit eutils if [[ ${PV} == "9999" ]] ; then EGIT_REPO_URI="http://repo.or.cz/r/jimtcl.git" @@ -40,15 +40,13 @@ src_prepare() { } src_configure() { - multijob_init - CCACHE=None multijob_child_init econf --with-jim-shared + CCACHE=None econf --with-jim-shared if use static-libs ; then # The build does not support doing both simultaneously. mkdir static-libs cd static-libs - CCACHE=None ECONF_SOURCE=${S} multijob_child_init econf + CCACHE=None ECONF_SOURCE=${S} econf fi - multijob_finish } src_compile() { -- 2.12.0