From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 86592139694 for ; Thu, 16 Mar 2017 22:48:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 72279E0C14; Thu, 16 Mar 2017 22:48:43 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1C3CBE0C04 for ; Thu, 16 Mar 2017 22:48:43 +0000 (UTC) Received: from localhost (dra13-4-78-234-166-189.fbx.proxad.net [78.234.166.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id BA45933BF1C for ; Thu, 16 Mar 2017 22:48:41 +0000 (UTC) Date: Thu, 16 Mar 2017 23:48:36 +0100 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] sys-devel/autoconf: Convert from eblits into an eclass, #586424 Message-ID: <20170316234836.6b30d496@gentoo.org> In-Reply-To: <1489690735.12313.1.camel@gentoo.org> References: <20170316093806.31977-1-mgorny@gentoo.org> <22730.25568.382258.703491@a1i15.kph.uni-mainz.de> <20170316131911.25e49c7d@gentoo.org> <22730.35784.80741.247631@a1i15.kph.uni-mainz.de> <20170316194209.62bdc737@gentoo.org> <1489690735.12313.1.camel@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: a3215a47-e0e3-4625-a3d0-a76e39636a16 X-Archives-Hash: b8ccb1af62f29ac74f2fabc9bd755bdc On Thu, 16 Mar 2017 19:58:55 +0100 Micha=C5=82 G=C3=B3rny wrote: > On czw, 2017-03-16 at 19:42 +0100, Alexis Ballier wrote: > > On Thu, 16 Mar 2017 13:57:44 +0100 > > Ulrich Mueller wrote: > > =20 > > > > > > > > On Thu, 16 Mar 2017, Alexis Ballier wrote: =20 > > > > Indeed, but that eclass fails to follow devmanual eclass 101 > > > > [1]: An eclass is a collection of code which can be used by > > > > more than one ebuild. =20 > > >=20 > > > Which is the case here: > > >=20 > > > sys-devel/autoconf/autoconf-2.13.ebuild | 10 +--- > > > sys-devel/autoconf/autoconf-2.59-r7.ebuild | 11 +--- > > > sys-devel/autoconf/autoconf-2.61-r2.ebuild | 11 +--- > > > sys-devel/autoconf/autoconf-2.62-r1.ebuild | 11 +--- > > > sys-devel/autoconf/autoconf-2.63-r1.ebuild | 11 +--- > > > sys-devel/autoconf/autoconf-2.64.ebuild | 11 +--- > > > sys-devel/autoconf/autoconf-2.65-r1.ebuild | 11 +--- > > > sys-devel/autoconf/autoconf-2.67.ebuild | 11 +--- > > > sys-devel/autoconf/autoconf-2.68.ebuild | 11 +--- > > > sys-devel/autoconf/autoconf-2.69-r2.ebuild | 11 +--- > > > sys-devel/autoconf/autoconf-9999.ebuild | 15 ++--- =20 > >=20 > >=20 > > You're trying to find loopholes in the wording here, aren't you ? :) > >=20 > > =20 > > > > While this eclass might be a good temporary solution, I find it > > > > a rather convincing argument for per-package eclasses :) =20 > > >=20 > > > Yes, if there was sufficient demand for such a feature, and it > > > would therefore reduce the number of global eclasses > > > significantly. IMHO it wouldn't be worth it for only a handful of > > > packages. =20 > >=20 > >=20 > > What do you consider demand ? > >=20 > > A handful of packages that have to write a hundred lines of > > boilerplate code to make it work isn't representative of any demand > > at all. I've already written in some bug some usecases I foresee > > for even a trivial 'include'. =20 >=20 > I would really appreciate if you stopped diverting this thread. If you > don't have anything to add regarding the patch in question, then > please hesitate from commenting. >=20 > If you love eblits that much, then please take appropriate measures to > get them into the next EAPI. Because so far your non-productive > comments on any effort of cleaning this mess up reach the level of > pure trolling. >=20 >=20 I reiterate: Your level of agressivity on the matter has reached very high levels. Calling people names, putting yourself as the savior for all our sins and callings other's work a mess is really getting ridiculous. Take a break, forget about your deadline, relax, and maybe you'll see things get resolved by themselves without all the drama. You'll gain in both ways. As for your accusation of diverting the thread, I'm sorry but I thought new eclass reviews on -dev was also, and essentially, about ensuring the eclass is the proper solution to the problem it claims to solve. I guess next time I'll rather focus on missing '|| die' that can easily be fixed later.