From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 529D1139694 for ; Sun, 12 Mar 2017 11:35:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0FEF7E0DCA; Sun, 12 Mar 2017 11:35:12 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B971EE0DC3 for ; Sun, 12 Mar 2017 11:35:11 +0000 (UTC) Received: from localhost (dra13-4-78-234-166-189.fbx.proxad.net [78.234.166.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id 161EA33BEFC for ; Sun, 12 Mar 2017 11:35:09 +0000 (UTC) Date: Sun, 12 Mar 2017 12:35:04 +0100 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 2/3] eutils.eclass: prune_libtool_files, make .pc subst errors fatal Message-ID: <20170312123504.3842f572@gentoo.org> In-Reply-To: <20170312110009.3109-3-mgorny@gentoo.org> References: <20170312103943.23092-1-mgorny@gentoo.org> <20170312110009.3109-1-mgorny@gentoo.org> <20170312110009.3109-3-mgorny@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 28223ed0-00aa-4e34-8fa1-29dd87135073 X-Archives-Hash: 712633b12e341daf7c40fb2c4ec43283 On Sun, 12 Mar 2017 12:00:08 +0100 Micha=C5=82 G=C3=B3rny wrote: > Make the substitution errors in prune_libtool_files logic fatal to > avoid the dependency of eqawarn. They're extremely unlikely to happen > anyway. --- > eclass/eutils.eclass | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass > index ab226b236a37..cb472caee1d4 100644 > --- a/eclass/eutils.eclass > +++ b/eclass/eutils.eclass > @@ -982,9 +982,10 @@ prune_libtool_files() { > for arg in > ${libs}; do if [[ ${arg} =3D=3D -l* ]]; then > if > [[ ${arg} =3D=3D '*$*' ]]; then > - > eqawarn "${FUNCNAME}: variable substitution likely failed in ${pc}" > - > eqawarn "(arg: ${arg})" > - > eqawarn "Most likely, you need to add virtual/pkgconfig to DEPEND." > + > eerror "${FUNCNAME}: variable substitution likely failed in ${pc}" > + > eerror "(arg: ${arg})" > + > eerror "Most likely, you need to add virtual/pkgconfig to DEPEND." > + > die "${FUNCNAME}: unsubstituted variable found in .pc" fi If you go that way then it would be best if this function had a=20 'has "virtual/pkgconfig" ${DEPEND} || die ...' kind of logic the message is more intended towards package maintainer and i would assume they have pkgconfig installed which means the failure will be on user's throat