From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 500DF139694 for ; Sun, 12 Mar 2017 11:02:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B8A7EE0DDE; Sun, 12 Mar 2017 11:00:23 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 79ACCE0DD8 for ; Sun, 12 Mar 2017 11:00:18 +0000 (UTC) Received: from localhost.localdomain (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id AD723341134; Sun, 12 Mar 2017 11:00:16 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-dev] [PATCH 2/3] eutils.eclass: prune_libtool_files, make .pc subst errors fatal Date: Sun, 12 Mar 2017 12:00:08 +0100 Message-Id: <20170312110009.3109-3-mgorny@gentoo.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170312110009.3109-1-mgorny@gentoo.org> References: <20170312103943.23092-1-mgorny@gentoo.org> <20170312110009.3109-1-mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Archives-Salt: c5f1c74f-7fcb-4de4-ad64-f72b39a4049a X-Archives-Hash: ed47a164cf6b40d61b17a5a3535f1011 Make the substitution errors in prune_libtool_files logic fatal to avoid the dependency of eqawarn. They're extremely unlikely to happen anyway. --- eclass/eutils.eclass | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass index ab226b236a37..cb472caee1d4 100644 --- a/eclass/eutils.eclass +++ b/eclass/eutils.eclass @@ -982,9 +982,10 @@ prune_libtool_files() { for arg in ${libs}; do if [[ ${arg} == -l* ]]; then if [[ ${arg} == '*$*' ]]; then - eqawarn "${FUNCNAME}: variable substitution likely failed in ${pc}" - eqawarn "(arg: ${arg})" - eqawarn "Most likely, you need to add virtual/pkgconfig to DEPEND." + eerror "${FUNCNAME}: variable substitution likely failed in ${pc}" + eerror "(arg: ${arg})" + eerror "Most likely, you need to add virtual/pkgconfig to DEPEND." + die "${FUNCNAME}: unsubstituted variable found in .pc" fi pc_libs+=( lib${arg#-l}.la ) -- 2.12.0