[gentoo-dev] [PATCH] eutils.eclass: Deprecate validate_desktop_entries

[gentoo-dev] [PATCH] eutils.eclass: Deprecate validate_desktop_entries

[Michał Górny]

The validate_desktop_entries function is redundant to the built-in
.desktop file checks done by Portage directly. It is used in total by
two packages for both of which bugs have been filed.
---
 eclass/eutils.eclass | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
index e398aafc464a..d91245495caa 100644
--- a/eclass/eutils.eclass
+++ b/eclass/eutils.eclass
@@ -883,6 +883,9 @@ _eutils_eprefix_init() {
 # @DESCRIPTION:
 # Validate desktop entries using desktop-file-utils
 validate_desktop_entries() {
+	eqawarn "validate_desktop_entries is deprecated and should be not be used."
+	eqawarn ".desktop file validation is done implicitly by Portage now."
+
 	_eutils_eprefix_init
 	if [[ -x "${EPREFIX}"/usr/bin/desktop-file-validate ]] ; then
 		einfo "Checking desktop entry validity"
-- 
2.12.0

Re: [gentoo-dev] [PATCH] eutils.eclass: Deprecate validate_desktop_entries

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]

On sob, 2017-03-11 at 14:06 +0100, Michał Górny wrote:
> The validate_desktop_entries function is redundant to the built-in
> .desktop file checks done by Portage directly. It is used in total by
> two packages for both of which bugs have been filed.
> ---
>  eclass/eutils.eclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
> index e398aafc464a..d91245495caa 100644
> --- a/eclass/eutils.eclass
> +++ b/eclass/eutils.eclass
> @@ -883,6 +883,9 @@ _eutils_eprefix_init() {
>  # @DESCRIPTION:
>  # Validate desktop entries using desktop-file-utils
>  validate_desktop_entries() {
> +	eqawarn "validate_desktop_entries is deprecated and should be not be used."
> +	eqawarn ".desktop file validation is done implicitly by Portage now."
> +
>  	_eutils_eprefix_init
>  	if [[ -x "${EPREFIX}"/usr/bin/desktop-file-validate ]] ; then
>  		einfo "Checking desktop entry validity"

Committed.

-- 
Best regards,
Michał Górny

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]