* [gentoo-dev] [PATCH] ruby-fakegem.eclass: Remove completely unnecessary 'eval ls'
@ 2017-02-23 18:34 Michał Górny
0 siblings, 0 replies; only message in thread
From: Michał Górny @ 2017-02-23 18:34 UTC (permalink / raw
To: gentoo-dev; +Cc: Michał Górny
Filename expansion is performed when the variable is referenced unquoted
already. There is really no need to call 'ls' on top of that, and even
less reason to wrap it all in 'eval'.
---
eclass/ruby-fakegem.eclass | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/eclass/ruby-fakegem.eclass b/eclass/ruby-fakegem.eclass
index 2fdbf6977707..1f740e8cb9d0 100644
--- a/eclass/ruby-fakegem.eclass
+++ b/eclass/ruby-fakegem.eclass
@@ -522,9 +522,8 @@ all_fakegem_install() {
if [[ -d "${bindir}" ]]; then
pushd "${bindir}" &>/dev/null || die
- local binaries=$(eval ls ${RUBY_FAKEGEM_BINWRAP})
- for binary in $binaries; do
- ruby_fakegem_binwrapper $binary
+ for binary in ${RUBY_FAKEGEM_BINWRAP}; do
+ ruby_fakegem_binwrapper "${binary}"
done
popd &>/dev/null || die
fi
--
2.11.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-23 18:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-23 18:34 [gentoo-dev] [PATCH] ruby-fakegem.eclass: Remove completely unnecessary 'eval ls' Michał Górny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox