From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9A90A1395E1 for ; Fri, 4 Nov 2016 12:20:35 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9B8DFE0BDC; Fri, 4 Nov 2016 12:20:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 514A1E0B86 for ; Fri, 4 Nov 2016 12:20:26 +0000 (UTC) Received: from localhost (131-9-170-31.fibre.evolix.net [31.170.9.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: aballier) by smtp.gentoo.org (Postfix) with ESMTPSA id 62193340EFD for ; Fri, 4 Nov 2016 12:20:24 +0000 (UTC) Date: Fri, 4 Nov 2016 13:20:16 +0100 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 2/2] cmake-utils.eclass: export compilers to environment instead of setting in toolchain file, bug 542530 Message-ID: <20161104132016.5acae7f3@gentoo.org> In-Reply-To: <1478130737-9780-3-git-send-email-reavertm@gmail.com> References: <1478130737-9780-1-git-send-email-reavertm@gmail.com> <1478130737-9780-3-git-send-email-reavertm@gmail.com> Organization: Gentoo X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 3205bc9e-d5cf-4d23-8114-e3a5a862e449 X-Archives-Hash: 6a9e14b0b1b306e6dcc02c99abcf972f On Thu, 3 Nov 2016 00:52:17 +0100 Maciej Mrozowski wrote: > From: Maciej Mrozowski > > --- > eclass/cmake-utils.eclass | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass > index 88d2163..23cc094 100644 > --- a/eclass/cmake-utils.eclass > +++ b/eclass/cmake-utils.eclass > @@ -525,13 +525,13 @@ enable_cmake-utils_src_configure() { > > local toolchain_file=${BUILD_DIR}/gentoo_toolchain.cmake > cat > ${toolchain_file} <<- _EOF_ || die > - SET (CMAKE_C_COMPILER $(tc-getCC)) > - SET (CMAKE_CXX_COMPILER $(tc-getCXX)) > - SET (CMAKE_Fortran_COMPILER $(tc-getFC)) > SET (CMAKE_AR $(type -P $(tc-getAR)) CACHE FILEPATH Have you tested cross compiling ? IIRC toolchain file is used *before* getting those vars from env and is used to determine system & compiler type. Without this you get bugs like #503216