[gentoo-dev] RFC: VCS element in metadata.xml

[gentoo-dev] RFC: VCS element in metadata.xml

[Robin H. Johnson]

For projects where no consistent remote-id is available yet, make it possible
to track where the source is available. The element may appear multiple times,
but values must be unique.

<vcs>git://git.gentoo.org/proj/genkernel.git</vcs>
<vcs>https://gitweb.gentoo.org/proj/genkernel.git/</vcs>

[gentoo-dev] [PATCH] metadata: add vcs tag

[Robin H. Johnson]

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
---
 metadata.dtd | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/metadata.dtd b/metadata.dtd
index d7ef81c..380fdbd 100644
--- a/metadata.dtd
+++ b/metadata.dtd
@@ -35,7 +35,7 @@
       <!ATTLIST flag name CDATA #REQUIRED >
 
   <!-- upstream metadata information (maintainers, upstream docs,..) -->
-  <!ELEMENT upstream (maintainer|changelog|doc|bugs-to|remote-id)* >
+  <!ELEMENT upstream (maintainer|changelog|doc|bugs-to|remote-id|vcs)* >
     <!-- Due to the limitation of DTD this will also allow a status
       attribute for the package maintainer element. Please note that
       the usage of the status attribute is nevertheless _only_ allowed
@@ -52,6 +52,8 @@
     <!-- specify a type of package identification tracker -->
     <!ELEMENT remote-id (#PCDATA)>
       <!ATTLIST remote-id type (bitbucket|cpan|cpan-module|cpe|cran|ctan|freecode|freshmeat|gentoo|github|gitlab|gitorious|google-code|launchpad|pear|pecl|pypi|rubyforge|rubygems|sourceforge|sourceforge-jp|vim) #REQUIRED>
+    <!-- URL where upstream code may be found -->
+    <!ELEMENT vcs (#PCDATA)>
 
   <!-- category/package information for cross-linking in descriptions
     and useflag descriptions -->
-- 
2.9.0

[gentoo-dev] [PATCH] metadata: add vcs tag

[Robin H. Johnson]

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
---
 metadata.xsd | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/metadata.xsd b/metadata.xsd
index cad8304..20423f8 100644
--- a/metadata.xsd
+++ b/metadata.xsd
@@ -83,6 +83,10 @@
 					<xs:selector xpath='doc'/>
 					<xs:field xpath='@lang'/>
 				</xs:unique>
+				<xs:unique name='upstreamVCSUniquityConstraint'>
+					<xs:selector xpath='vcs'/>
+					<xs:field xpath='@fake-only-once'/>
+				</xs:unique>
 			</xs:element>
 			<xs:element name='use' type='useType'>
 				<xs:unique name='flagUniquityConstraint'>
-- 
2.9.0

Re: [gentoo-dev] RFC: VCS element in metadata.xml

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

On Wed, 12 Oct 2016 09:44:39 -0700
"Robin H. Johnson" <robbat2@gentoo.org> wrote:

> For projects where no consistent remote-id is available yet, make it possible
> to track where the source is available. The element may appear multiple times,
> but values must be unique.
> 
> <vcs>git://git.gentoo.org/proj/genkernel.git</vcs>
> <vcs>https://gitweb.gentoo.org/proj/genkernel.git/</vcs>

The second form is ambiguous, as it doesn't declare the VCS
in question. To follow a precedence, I suggest using the format from
repositories.xml.

Furthermore, you are missing the most important part -- patch for
GLEP 68.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 931 bytes --]

Re: [gentoo-dev] [PATCH] metadata: add vcs tag

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

On Wed, 12 Oct 2016 09:44:41 -0700
"Robin H. Johnson" <robbat2@gentoo.org> wrote:

> Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
> ---
>  metadata.xsd | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/metadata.xsd b/metadata.xsd
> index cad8304..20423f8 100644
> --- a/metadata.xsd
> +++ b/metadata.xsd
> @@ -83,6 +83,10 @@
>  					<xs:selector xpath='doc'/>
>  					<xs:field xpath='@lang'/>
>  				</xs:unique>
> +				<xs:unique name='upstreamVCSUniquityConstraint'>
> +					<xs:selector xpath='vcs'/>
> +					<xs:field xpath='@fake-only-once'/>
> +				</xs:unique>

Is there a reason to disallow more than one occurrence of <vcs/>?

>  			</xs:element>
>  			<xs:element name='use' type='useType'>
>  				<xs:unique name='flagUniquityConstraint'>

You are missing actually adding the element... You just added
a constraint on a non-existing element.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 931 bytes --]

Re: [gentoo-dev] [PATCH] metadata: add vcs tag

[Gilles Dartiguelongue]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Le mercredi 12 octobre 2016 à 09:44 -0700, Robin H. Johnson a écrit :
> 
> [...]
> @@ -52,6 +52,8 @@
>      <!-- specify a type of package identification tracker -->
>      <!ELEMENT remote-id (#PCDATA)>
>        <!ATTLIST remote-id type (bitbucket|cpan|cpan-
> module|cpe|cran|ctan|freecode|freshmeat|gentoo|github|gitlab|gitoriou
> s|google-
> code|launchpad|pear|pecl|pypi|rubyforge|rubygems|sourceforge|sourcefo
> rge-jp|vim) #REQUIRED>
> +    <!-- URL where upstream code may be found -->
> +    <!ELEMENT vcs (#PCDATA)>

I am probably nitpicking here but if you expect this element to contain
a valid URL, then maybe using #CDATA makes more sense ?

-- 
Gilles Dartiguelongue <eva@gentoo.org>
Gentoo

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 335 bytes --]