From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 29DEA13832E for ; Sat, 6 Aug 2016 14:05:55 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EBFA3E0B77; Sat, 6 Aug 2016 14:05:46 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E3929E0B5A for ; Sat, 6 Aug 2016 14:05:45 +0000 (UTC) Received: from localhost (unknown [185.31.165.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bircoph) by smtp.gentoo.org (Postfix) with ESMTPSA id A2375340A03 for ; Sat, 6 Aug 2016 14:05:43 +0000 (UTC) Date: Sat, 6 Aug 2016 17:05:39 +0300 From: Andrew Savchenko To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] subversion.eclass: support for EAPI 6 Message-Id: <20160806170539.82e500a7965303b5526c7689@gentoo.org> In-Reply-To: <20160730123407.1d5ac5b737bc74d7c1684a92@gentoo.org> References: <20160729183158.254fcaefbe2485ad8ad5e3d8@gentoo.org> <20160729174241.337d0793.mgorny@gentoo.org> <20160729223601.b66b48bb392db1cb391f5049@gentoo.org> <20160730073708.7dcfb01a.mgorny@gentoo.org> <20160730123407.1d5ac5b737bc74d7c1684a92@gentoo.org> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA512"; boundary="Signature=_Sat__6_Aug_2016_17_05_39_+0300_h4WJowEsvHFiNXYM" X-Archives-Salt: ca1c74b3-6806-4c84-8822-922dda3f3f13 X-Archives-Hash: 8df55dfb0db71534e9a01c27451b150c --Signature=_Sat__6_Aug_2016_17_05_39_+0300_h4WJowEsvHFiNXYM Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, 30 Jul 2016 12:34:07 +0300 Andrew Savchenko wrote: > On Sat, 30 Jul 2016 07:37:08 +0200 Micha=C5=82 G=C3=B3rny wrote: > > > @@ -116,7 +123,8 @@ ESVN_PROJECT=3D"${ESVN_PROJECT:-${PN/-svn}}" > > > =20 > > > # @ECLASS-VARIABLE: ESVN_BOOTSTRAP > > > # @DESCRIPTION: > > > -# bootstrap script or command like autogen.sh or etc.. > > > +# Bootstrap script or command like autogen.sh or etc.. > > > +# Removed in EAPI 6 and later. > > > ESVN_BOOTSTRAP=3D"${ESVN_BOOTSTRAP:-}" > > > =20 > > > # @ECLASS-VARIABLE: ESVN_PATCHES > > > @@ -127,6 +135,8 @@ ESVN_BOOTSTRAP=3D"${ESVN_BOOTSTRAP:-}" > > > # > > > # Patches are searched both in ${PWD} and ${FILESDIR}, if not found = in either > > > # location, the installation dies. > > > +# > > > +# Removed in EAPI 6 and later, use PATCHES instead. > > > ESVN_PATCHES=3D"${ESVN_PATCHES:-}" > >=20 > > It would be a good idea to check if the variables are set and die if > > they are, so people don't accidentally use them. >=20 > Impossible to implement. These variables (as well as all other > ESVN_* variables) are usually set after subversion eclass is > inherited. And even if I'll duplicate this check in all available > functions (which is ridiculous by itself), it still will not help, > since several functions are removed from EAPI 6 and people may > rely on default behaviour of src_prepare() alone. >=20 > > > # @ECLASS-VARIABLE: ESVN_RESTRICT > > > @@ -355,7 +365,10 @@ subversion_fetch() { > > > # @FUNCTION: subversion_bootstrap > > > # @DESCRIPTION: > > > # Apply patches in ${ESVN_PATCHES} and run ${ESVN_BOOTSTRAP} if spec= ified. > > > +# Removed in EAPI 6 and later. > > > subversion_bootstrap() { > > > + has "${EAPI:-0}" 6 && die "${FUNCNAME[1]} is removed from subversio= n.eclass in EAPI 6 and later" > > > + > >=20 > > Reverse the logic. This will require updating in every EAPI while it is > > rather unlikely the next EAPIs will return to previous behavior. >=20 > Done. No further comments for a week =3D> in the tree now. Thank you for review. Best regards, Andrew Savchenko --Signature=_Sat__6_Aug_2016_17_05_39_+0300_h4WJowEsvHFiNXYM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXpe6zAAoJEPZTWjO6HuSN9t0P/3Y+egmPQAm9sS+tmhPKYro8 Jy8MF6zXBYOxgoShh5mu6iUdXouA005agR812obRNuLY9L5HhzazIU8H0s4aoCOL m5upqvLPd7+JiSOQMDII1qOQB0DVvWIT/lTRtxZ9fWhbIQFGGWF556FZjfnxCcIi qN3znu16Dn/pQvCokUlsZ06VKRlFPaQUIxbPoBd+yL7YIVi605pYDy+LEAIiqC94 CgajHWHDE417maM/Fzuvv7f2M1qCRMA/dGNQIOsBhYERw99UsdeVvt9y8/IgesKx 1F6sRBki14xbSK87e+vrh7AuezKBoUo9d3r2yIkDAOIWpLMF5Mn/7ebBjzmDcWOL LhEezyZOghf/wFiluVdLyXjrARSodXlNo3iFH3qvONTq1PsavbKK9tLRohASR0uA KEvAyJteH8lzaeizBBtoT7QQI3GdKE88pbHQCNB697a8ecD6BDa7reYii5Gsia8j yWoBQnw1YDxYDhxvqpand4sMkoKZW+q4vEs6lHD743dRnI9PxxyBcFrE2nBSabSi v8JZQOW3xKnOaSrkhS1CRACb4NLchg4v0iU9Grek9hQOAWtJ1VcXvVAjooJUP2Ju QBQgMXLl1N+4eXRw3ZY2DVYu+ky/zEubncAozUzO/gQEeUZHmFwNw1YuD6BX0mwW M0IK9mS5F8QSS/NBoCRe =s2ow -----END PGP SIGNATURE----- --Signature=_Sat__6_Aug_2016_17_05_39_+0300_h4WJowEsvHFiNXYM--