From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 52BBD13832E for ; Fri, 29 Jul 2016 15:43:10 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 63E76E09B2; Fri, 29 Jul 2016 15:42:55 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 484EAE0914 for ; Fri, 29 Jul 2016 15:42:54 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id B7104340D4F; Fri, 29 Jul 2016 15:42:52 +0000 (UTC) Date: Fri, 29 Jul 2016 17:42:40 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: Andrew Savchenko Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] subversion.eclass: support for EAPI 6 Message-ID: <20160729174241.337d0793.mgorny@gentoo.org> In-Reply-To: <20160729183158.254fcaefbe2485ad8ad5e3d8@gentoo.org> References: <20160729183158.254fcaefbe2485ad8ad5e3d8@gentoo.org> Organization: Gentoo X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/fUyKqHJprnIi8QTbrLf5uRd"; protocol="application/pgp-signature" X-Archives-Salt: 8bdff499-aa23-4eab-bcf8-722c41c532a0 X-Archives-Hash: 6006dea3bb42b8db919414dcd6006d59 --Sig_/fUyKqHJprnIi8QTbrLf5uRd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 29 Jul 2016 18:31:58 +0300 Andrew Savchenko wrote: > diff --git a/eclass/subversion.eclass b/eclass/subversion.eclass > index c45c725..49040a4 100644 > --- a/eclass/subversion.eclass > +++ b/eclass/subversion.eclass > @@ -434,6 +434,7 @@ subversion_src_unpack() { > # Default src_prepare. Bootstrap. > subversion_src_prepare() { > subversion_bootstrap || die "${ESVN}: unknown problem occurred in subve= rsion_bootstrap." > + [[ ${EAPI:-0} -ge 6 ]] && eapply_user EAPI is not always a number, so this is wrong. Furthermore, since it didn't work in EAPI 6 anyway, please take a look into improving this eclass for EAPI 6. In particular: - add a proper EAPI check preventing it from implicitly being enabled in new EAPIs, - disable subversion_bootstrap() along with all the relevant facilities in EAPI 6 and later, therefore also stopping exporting src_prepare(). --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/fUyKqHJprnIi8QTbrLf5uRd Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJXm3lxXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2REJCMDdDQzRGMERBRDA2RUEwQUZFNDFC MDdBMUFFQUVGQjQ0NjRFAAoJELB6GurvtEZOyMIQAI+IYhDJm5k2CLK2KVjpxx2Y wmexZF/jAWCUm2xe8SuiC2b4QUGCinnckQW21JL55eV+FKL4bNPVOw7GPXbNgOmn VmI/C8A8dtudg4Guxyb+ue9+UNUMI/yvoHvlmAHEmmjtqpsRTb/eKCESW+VMEJbA sp3lZF425q/khkwyEleHGEu0icjhuJLkglptsMLB2j6qXZDDFIzhBMy4j3F/PH5H k5urK9VlVjZPpGxPAaeUvl5JtPCV1trUhD4qMy5Gw0Dolome05MaB75U8M6EFyZ1 j1Mb+lF7ewTe+8chLORMn6hm7Y1J5YflNbH/1LMW1FzzigIKLYesMzvnDF4cbvEH qpK1phjpAJLAEeeSIalm7zP9t6fzuX7LJyF+Ssn686H6/a4ET8aKIOi4vx3lB0Go 0IxHJHumkrw6+jz2jSlWA7W6CAd3CvFtoai4JWn1+8ExUS9WLkcb2HLjPQUJGmi4 ndkS3uj+13NCRnYnkugOU7JAxV4PI/TsCtF4hehYjpCUN9gYldu+HyOjfwKIukYF T52TdMUt2mxSENHo8xbZjTpbOC20BUs22tJxRg4kWwlDPhMLEN1if7DNkiViQ/Fa J44IYFuGelj4cAyswtpz/N4HXjNY2l6CCgdFjtyG0XvzReRQ5uwXQQ5WKjb30YGi 0nMatGTlyXvAXoOKWV7z =1jpa -----END PGP SIGNATURE----- --Sig_/fUyKqHJprnIi8QTbrLf5uRd--