Re: [gentoo-dev] [PATCH] subversion.eclass: support for EAPI 6

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

On Fri, 29 Jul 2016 18:31:58 +0300
Andrew Savchenko <bircoph@gentoo.org> wrote:

> diff --git a/eclass/subversion.eclass b/eclass/subversion.eclass
> index c45c725..49040a4 100644
> --- a/eclass/subversion.eclass
> +++ b/eclass/subversion.eclass
> @@ -434,6 +434,7 @@ subversion_src_unpack() {
>  # Default src_prepare. Bootstrap.
>  subversion_src_prepare() {
>  	subversion_bootstrap || die "${ESVN}: unknown problem occurred in subversion_bootstrap."
> +	[[ ${EAPI:-0} -ge 6 ]] && eapply_user

EAPI is not always a number, so this is wrong.

Furthermore, since it didn't work in EAPI 6 anyway, please take a look
into improving this eclass for EAPI 6. In particular:

- add a proper EAPI check preventing it from implicitly being enabled
  in new EAPIs,

- disable subversion_bootstrap() along with all the relevant facilities
  in EAPI 6 and later, therefore also stopping exporting src_prepare().

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]