From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: kde@gentoo.org, tommy@gentoo.org
Subject: Re: [gentoo-dev] cmake-utils.eclass: fixes to ninja MAKEOPTS conversion
Date: Thu, 26 May 2016 10:10:33 +0200 [thread overview]
Message-ID: <20160526101033.7af217dc.mgorny@gentoo.org> (raw)
In-Reply-To: <1456686118-28043-1-git-send-email-mgorny@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
On Sun, 28 Feb 2016 20:01:56 +0100
Michał Górny <mgorny@gentoo.org> wrote:
> Hello,
>
> Just a quick two patches against cmake-utils that fix MAKEOPTS->ninja
> conversion. In particular:
>
> 1. -k never takes value in make, so do not account for that, and always
> convert '-k' to '-k 0',
>
> 2. -j and -l have optional values in make, so figure out if we're being
> passed a correct value and use '-j 9999' and '-l 0' otherwise.
After the three-month review period I've decided to go ahead and push
it.
--
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]
next prev parent reply other threads:[~2016-05-26 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 19:01 [gentoo-dev] cmake-utils.eclass: fixes to ninja MAKEOPTS conversion Michał Górny
2016-02-28 19:01 ` [gentoo-dev] [PATCH 1/2] cmake-utils.eclass: _ninjaopts_from_makeopts, fix handling of -k Michał Górny
2016-02-28 19:01 ` [gentoo-dev] [PATCH 2/2] cmake-utils.eclass: _ninjaopts_from_makeopts, fix plain '-j' and '-l' Michał Górny
2016-05-26 8:10 ` Michał Górny [this message]
2016-05-26 13:24 ` [gentoo-dev] cmake-utils.eclass: fixes to ninja MAKEOPTS conversion rindeal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526101033.7af217dc.mgorny@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=kde@gentoo.org \
--cc=tommy@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox