From: Andrew Savchenko <bircoph@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [RFC] Enable CMAKE_WARN_UNUSED_CLI by default in cmake-utils for EAPI>=6
Date: Wed, 18 May 2016 09:22:53 +0300 [thread overview]
Message-ID: <20160518092253.dcc8a44b4c7e7cb8a07011c4@gentoo.org> (raw)
In-Reply-To: <2425813.40BMEBc0ED@liwardyna>
[-- Attachment #1: Type: text/plain, Size: 2033 bytes --]
On Mon, 02 May 2016 18:06:44 +0200 Maciej Mrozowski wrote:
> Hello,
>
> General advise: do not convert ebuilds inheriting cmake-utils to EAPI 6 unless
> you know what you are doing (you are fully aware of eclass behaviour removed
> with https://bugs.gentoo.org/show_bug.cgi?id=514384).
>
> Background:
>
> Pre EAPI-6 cmake-utils.eclass contained certain feature to mitigate CMake
> variable case changes done by upstream.
> This feature was explicitly removed with
> https://bugs.gentoo.org/show_bug.cgi?id=514384 and no alternative was
> proposed.
> It opened new area of possible ebuild regression bugs when switching to EAPI-6
> for ebuilds inheriting cmake-utils.eclass.
>
> Unfortunately there is common misconception, also among developers, that it's
> sufficient to simply replace "${cmake-utils_use_with foo)" with "-DWITH_foo=ON"
> etc.
> This is MOST OF THE TIME not the case.
> When converting cmake-utils ebuild to EAPI>=6, one needs to consult
> CMakeLists.txt wrt case each variable is written with since CMake is case-
> sensitive and WITH_FOO != WITH_foo != WITH_Foo.
>
> Proposal:
>
> CMake allows warning about unused CMake variables passed by CLI. Since this is
> how Gentoo passes ebuild configuration options, it's proposed to enable this
> feature.
> Unfortunately it won't fail compilation but at least it gives a chance to spot
> case mismatch when reading build output.
>
> Future thoughts:
>
> For better damage control it's technically possible to extend configure phase
> of cmake-utuls eclass to check mycmakeargs against parsed package buildsystem
> but this might not be very reliable.
For me the real confusion was from this line:
die "${FUNCNAME[1]} is banned in EAPI 6 and later: use -D$1${arg}=\"\$(usex $2)\" instead"
It recommends to use ${arg} without any warning about case, so when I just
copied what it recommends: -DWITH_nls="$(usex nls)", I had a nice surprise
and fun debugging.
Best regards,
Andrew Savchenko
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-18 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 16:06 [gentoo-dev] [RFC] Enable CMAKE_WARN_UNUSED_CLI by default in cmake-utils for EAPI>=6 Maciej Mrozowski
2016-05-02 16:13 ` [gentoo-dev] " Maciej Mrozowski
2016-05-17 23:19 ` Maciej Mrozowski
2016-05-18 6:22 ` Andrew Savchenko [this message]
2016-05-18 20:28 ` [gentoo-dev] " Maciej Mrozowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518092253.dcc8a44b4c7e7cb8a07011c4@gentoo.org \
--to=bircoph@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox